From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil Date: Tue, 10 Jan 2023 20:12:54 -0600 Message-ID: References: Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26980"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.13; emacs 29.0.60 Cc: michael.albinus@gmx.de, 60722@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 11 03:37:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFQzV-0006o0-5d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Jan 2023 03:37:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFQzB-0002uv-2g; Tue, 10 Jan 2023 21:37:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFQz9-0002un-Do for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2023 21:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFQz8-0001IQ-P3 for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2023 21:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFQz8-0003YL-9b for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2023 21:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ruijie Yu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2023 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60722-submit@debbugs.gnu.org id=B60722.167340458713595 (code B ref 60722); Wed, 11 Jan 2023 02:37:02 +0000 Original-Received: (at 60722) by debbugs.gnu.org; 11 Jan 2023 02:36:27 +0000 Original-Received: from localhost ([127.0.0.1]:41480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFQyY-0003XD-IP for submit@debbugs.gnu.org; Tue, 10 Jan 2023 21:36:26 -0500 Original-Received: from netyu.xyz ([152.44.41.246]:49688 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFQyX-0003X4-6O for 60722@debbugs.gnu.org; Tue, 10 Jan 2023 21:36:25 -0500 Original-Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 713ce07c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 11 Jan 2023 02:36:23 +0000 (UTC) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253125 Archived-At: Jim Porter writes: > X-Debbugs-Cc: michael.albinus@gmx.de > > Starting with "sudo emacs -Q -f eshell", notice that the prompt looks like: > > /home/user # > > Now start "emacs -Q -f eshell": > > ~ $ cd /sudo:: > /sudo:root@huginn:~ $ > > Notice that the prompt sigil is still "$" instead of "#". I think it would be > better to indicate that you have a root shell by using "#" here. > > Attached is a patch to do this. It adds a new function, 'user-uid-for-file', > which is aware of file name handlers. Then, Tramp adds the appropriate > handler. Now, Eshell can use that function and we get the prompt sigil we > expect. > > [2. text/plain; 0001-Add-user-uid-for-file-to-get-the-effective-UID-for-r.patch]... Haven't looked into the patch, but I wonder if it addresses multi-hop scenarios like the following: 1. /sudo:admin@localhost|sudo:: 2. /sudo:|sudo:another_user@localhost:: 3. /sshx:admin@remote|sudo:: 4. /sudo:|sshx:admin@remote:: 5. /doas:: 6. /sshx:root@localhost: Best, RY