From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h Date: Wed, 11 Jul 2012 15:14:18 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1342034086 12886 80.91.229.3 (11 Jul 2012 19:14:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Jul 2012 19:14:46 +0000 (UTC) Cc: Paul Eggert To: 11914@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 11 21:14:45 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sp2N0-0001wn-TG for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jul 2012 21:14:43 +0200 Original-Received: from localhost ([::1]:47248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp2Mz-0003QK-Tc for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jul 2012 15:14:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp2Mu-0003QA-Pj for bug-gnu-emacs@gnu.org; Wed, 11 Jul 2012 15:14:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sp2Mt-0001Ri-9v for bug-gnu-emacs@gnu.org; Wed, 11 Jul 2012 15:14:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp2Mt-0001Rc-6x for bug-gnu-emacs@gnu.org; Wed, 11 Jul 2012 15:14:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sp2SA-0007Dg-19; Wed, 11 Jul 2012 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: eggert@cs.ucla.edu, bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jul 2012 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org X-Debbugs-Original-Xcc: Paul Eggert Original-Received: via spool by submit@debbugs.gnu.org id=B.134203439127728 (code B ref -1); Wed, 11 Jul 2012 19:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Jul 2012 19:19:51 +0000 Original-Received: from localhost ([127.0.0.1]:33894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Ry-0007DA-Pn for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:51 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:37588) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Rv-0007D1-GL for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:48 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sp2Mc-0000dZ-U1; Wed, 11 Jul 2012 15:14:18 -0400 X-Spook: Maple FBI Craig Livingstone [Hello to all my friends and X-Ran: \Cc0~bVBCN$XLGA<- List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61826 Archived-At: Package: emacs Version: 24.1.50 Severity: minor (Very similar to bug#11905) src/s/sol2-6.h does this: /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root. ghazi@caip.rutgers.edu, 7/21/97. Don't redefine if already defined (e.g., by config.h). */ #ifndef HAVE_LIBKSTAT #define HAVE_LIBKSTAT #endif The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling this properly via configure checks (?), so there is no need for Emacs's src/s/sol2-6.h to define HAVE_LIBKSTAT.