* bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
@ 2012-07-11 19:14 Glenn Morris
2012-07-11 20:41 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2012-07-11 19:14 UTC (permalink / raw)
To: 11914; +Cc: Paul Eggert
Package: emacs
Version: 24.1.50
Severity: minor
(Very similar to bug#11905)
src/s/sol2-6.h does this:
/* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
ghazi@caip.rutgers.edu, 7/21/97. Don't redefine if already defined
(e.g., by config.h). */
#ifndef HAVE_LIBKSTAT
#define HAVE_LIBKSTAT
#endif
The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
this properly via configure checks (?), so there is no need for Emacs's
src/s/sol2-6.h to define HAVE_LIBKSTAT.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
2012-07-11 19:14 bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h Glenn Morris
@ 2012-07-11 20:41 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2012-07-11 20:41 UTC (permalink / raw)
To: Glenn Morris; +Cc: 11914-done
On 07/11/2012 12:14 PM, Glenn Morris wrote:
> there is no need for Emacs's
> src/s/sol2-6.h to define HAVE_LIBKSTAT.
Yes, thanks, I made that change in trunk bzr 109034.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-11 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 19:14 bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h Glenn Morris
2012-07-11 20:41 ` Paul Eggert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.