From: Glenn Morris <rgm@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28396@debbugs.gnu.org
Subject: bug#28396: 26.0.50; display-line-numbers not saved by Save Options
Date: Tue, 21 Nov 2017 19:44:05 -0500 [thread overview]
Message-ID: <saefor87my.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83mv64w5le.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Sep 2017 13:04:29 +0300")
Eli Zaretskii wrote:
> emacs -Q
> Click Options in the menu bar
> Select Show/Hide->Line Numbers For All Lines->Global Line Numbers Mode
> Click Options->Save Options
>
> The result is that the setting of global-display-line-numbers-mode is
> not saved on the init file.
commit daa959e (HEAD, origin/emacs-26, emacs-26)
Date: Tue Nov 21 19:42:32 2017 -0500
* lisp/menu-bar.el (menu-bar-options-save):
Add global-display-line-numbers-mode. (Bug#28396)
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 972f84e..9ff3de1 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -669,7 +669,8 @@ menu-bar-options-save
(let ((need-save nil))
;; These are set with menu-bar-make-mm-toggle, which does not
;; put on a customized-value property.
- (dolist (elt '(line-number-mode column-number-mode size-indication-mode
+ (dolist (elt '(global-display-line-numbers-mode
+ line-number-mode column-number-mode size-indication-mode
cua-mode show-paren-mode transient-mark-mode
blink-cursor-mode display-time-mode display-battery-mode
;; These are set by other functions that don't set
> Note that the solution should also save the sub-mode, when the user
> selects, say, Relative Line Numbers.
Buffer-local variables like display-line-numbers don't play well with
Customize.
next prev parent reply other threads:[~2017-11-22 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 10:04 bug#28396: 26.0.50; display-line-numbers not saved by Save Options Eli Zaretskii
2017-11-22 0:44 ` Glenn Morris [this message]
2017-11-22 1:18 ` Glenn Morris
2017-11-22 3:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=saefor87my.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=28396@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.