From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Mon, 07 Jun 2010 17:59:29 +0200 Message-ID: References: <1275757657-15244-1-git-send-email-julien@danjou.info> <87ljar3uug.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1275945153 10360 80.91.229.12 (7 Jun 2010 21:12:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Jun 2010 21:12:33 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 07 23:12:30 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OLjcR-00074p-Mx for ged-emacs-devel@m.gmane.org; Mon, 07 Jun 2010 23:12:28 +0200 Original-Received: from localhost ([127.0.0.1]:44497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLjcQ-0005HF-Ug for ged-emacs-devel@m.gmane.org; Mon, 07 Jun 2010 17:12:27 -0400 Original-Received: from [140.186.70.92] (port=54664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLejg-00039L-LI for emacs-devel@gnu.org; Mon, 07 Jun 2010 11:59:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLejb-0002nJ-J2 for emacs-devel@gnu.org; Mon, 07 Jun 2010 11:59:36 -0400 Original-Received: from coquelicot-s.easter-eggs.com ([213.215.37.94]:51030) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLejb-0002n1-Dx for emacs-devel@gnu.org; Mon, 07 Jun 2010 11:59:31 -0400 Original-Received: from cigue.easter-eggs.fr (cigue.easter-eggs.fr [10.0.0.33]) by rose.easter-eggs.fr (Postfix) with ESMTPS id 3EB341402D; Mon, 7 Jun 2010 17:59:23 +0200 (CEST) Original-Received: from jdanjou by cigue.easter-eggs.fr with local (Exim 4.72) (envelope-from ) id 1OLejZ-0005nr-2w; Mon, 07 Jun 2010 17:59:29 +0200 In-Reply-To: (Michael Albinus's message of "Mon, 07 Jun 2010 17:36:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Mon, 07 Jun 2010 17:09:13 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125614 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jun 07 2010, Michael Albinus wrote: > They are not mandatory functionally (there is no D-Bus error), but as > you say, the result is weird. I like Stefan's idea to make them mandatory > parameters; if somebody really wants to left them empty, she could pass "= ". If you really want, I will amend the patch to add at list `:title' as mandatory. OTOH body is really optionnal, quoting specs[1]: ``If the body is omitted, just the summary is displayed.'' > Grrr. I need new glasses! The fact you missed it also proves it might be so obvious at first read. ;) > Maybe you have disabled D-Bus error in one way or the other, I've got an > error. Did you run dbus-monitor in parallel, during tests? Yes, and I really saw nothing. I don't think I disabled any D-Bus error. I just saw an empty array []. [1] http://www.galago-project.org/specs/notification/0.9/x81.html Anyhow, thanks much for the review Michael. Cheers, =2D-=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwNF2EACgkQpGK1HsL+5c0opgCgt87sV163ZsZ0ItD7LWUXXzGc ZHcAoMstXB0loXO7wKKhEyj53eZHsOOc =SUPe -----END PGP SIGNATURE----- --=-=-=--