From: Julien Danjou <julien@danjou.info>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add notifications.el
Date: Mon, 07 Jun 2010 17:59:29 +0200 [thread overview]
Message-ID: <sa3wrua25r2.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <nqocfm4zyz.fsf@alcatel-lucent.com> (Michael Albinus's message of "Mon, 07 Jun 2010 17:36:04 +0200")
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
On Mon, Jun 07 2010, Michael Albinus wrote:
> They are not mandatory functionally (there is no D-Bus error), but as
> you say, the result is weird. I like Stefan's idea to make them mandatory
> parameters; if somebody really wants to left them empty, she could pass "".
If you really want, I will amend the patch to add at list `:title' as
mandatory. OTOH body is really optionnal, quoting specs[1]:
``If the body is omitted, just the summary is displayed.''
> Grrr. I need new glasses!
The fact you missed it also proves it might be so obvious at first
read. ;)
> Maybe you have disabled D-Bus error in one way or the other, I've got an
> error. Did you run dbus-monitor in parallel, during tests?
Yes, and I really saw nothing. I don't think I disabled any D-Bus
error. I just saw an empty array [].
[1] http://www.galago-project.org/specs/notification/0.9/x81.html
Anyhow, thanks much for the review Michael.
Cheers,
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-06-07 15:59 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 17:07 [PATCH] Add notifications.el Julien Danjou
2010-06-07 12:12 ` Michael Albinus
2010-06-07 13:31 ` Stefan Monnier
2010-06-07 15:17 ` Julien Danjou
2010-06-07 15:18 ` Julien Danjou
2010-06-07 15:36 ` Michael Albinus
2010-06-07 15:59 ` Julien Danjou [this message]
2010-06-07 22:28 ` Davis Herring
2010-06-08 8:08 ` Julien Danjou
2010-06-08 8:45 ` Julien Danjou
2010-06-08 12:42 ` Michael Albinus
2010-06-08 13:07 ` Julien Danjou
2010-06-10 23:16 ` Jan Moringen
2010-06-11 6:46 ` Julien Danjou
[not found] ` <3277_1276238795_o5B6kZER023748_87aar22hj1.fsf@keller.adm.naquadah.org>
2010-06-11 7:30 ` Jan Moringen
2010-06-11 9:15 ` Julien Danjou
2010-06-11 9:27 ` Jan Moringen
2010-06-11 10:25 ` Michael Albinus
2010-06-09 0:37 ` Stefan Monnier
2010-06-09 7:44 ` Michael Albinus
2010-06-09 18:18 ` Tassilo Horn
2010-06-09 18:53 ` Julien Danjou
2010-06-09 19:16 ` Tassilo Horn
2010-06-09 19:47 ` Julien Danjou
2010-06-09 20:10 ` Tassilo Horn
2010-06-09 20:39 ` Stefan Monnier
2010-06-09 20:58 ` Julien Danjou
2010-06-10 0:26 ` Stefan Monnier
2010-06-10 6:33 ` Tassilo Horn
2010-06-10 7:55 ` Julien Danjou
2010-06-10 8:26 ` Michael Albinus
2010-06-10 8:43 ` [PATCH] Passes notification id as argument of on-action and on-close functions Julien Danjou
2010-06-10 13:00 ` Michael Albinus
2010-06-10 13:08 ` Julien Danjou
2010-06-10 13:25 ` Michael Albinus
2010-06-10 15:20 ` Juri Linkov
2010-06-10 15:45 ` Michael Albinus
2010-06-10 16:56 ` Juri Linkov
2010-06-10 18:41 ` Michael Albinus
2010-06-10 18:53 ` Stefan Monnier
2010-06-10 20:23 ` Juri Linkov
2010-06-11 0:43 ` Stefan Monnier
2010-06-11 6:35 ` Daniel Pittman
2010-06-11 8:07 ` Juri Linkov
2010-06-11 13:20 ` Stefan Monnier
2010-06-11 8:06 ` Juri Linkov
2010-06-11 13:21 ` Stefan Monnier
2010-06-11 14:54 ` Chong Yidong
2010-06-11 15:51 ` Stefan Monnier
2010-06-11 19:14 ` Juri Linkov
2010-06-12 6:20 ` Dan Nicolaescu
2010-06-12 20:10 ` Juri Linkov
2010-06-12 20:49 ` Stefan Monnier
2010-06-14 15:51 ` Juri Linkov
2010-06-14 19:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sa3wrua25r2.fsf@cigue.easter-eggs.fr \
--to=julien@danjou.info \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.