From: Julien Danjou <julien@danjou.info>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Jan Djärv" <jan.h.d@swipnet.se>, emacs-devel@gnu.org
Subject: Re: Type-error in C code
Date: Fri, 12 Nov 2010 15:21:06 +0100 [thread overview]
Message-ID: <sa362w2d3n1.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <jwv4obmodah.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 12 Nov 2010 09:02:10 -0500")
On Fri, Nov 12 2010, Stefan Monnier wrote:
> static void
> set_wm_state (Lisp_Object frame, int add, Atom atom, Atom value)
> {
> struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (XFRAME (frame));
>
> x_send_client_event (frame, make_number (0), frame,
> dpyinfo->Xatom_net_wm_state,
> make_number (32),
> /* 1 = add, 0 = remove */
> Fcons
> (make_number (add ? 1 : 0),
> Fcons
> (atom,
> value != 0 ? value : Qnil)));
> }
>
> The error is to put an "Atom" into a cons cell: those can only hold
> Lisp_Objects. The usual compilation flags won't catch the error because
> both types are actually some kind of integer, but if you
> compile --enable-use-lisp-union-type, the C compiler will
> dutyfully burp.
Good catch Stefan. I should use this flag to compile my code now.
The fix should be easy I think, you just need to replace atom with
make_number (atom).
I can provide a patch is that handier.
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
next prev parent reply other threads:[~2010-11-12 14:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 14:02 Type-error in C code Stefan Monnier
2010-11-12 14:21 ` Julien Danjou [this message]
2010-11-12 15:12 ` Jan Djärv
2010-11-12 15:22 ` Julien Danjou
2010-11-12 15:28 ` Julien Danjou
2010-11-12 15:32 ` Julien Danjou
2010-11-12 15:48 ` Eli Zaretskii
2010-11-12 15:58 ` Julien Danjou
2010-11-12 16:06 ` John Yates
2010-11-12 16:20 ` Eli Zaretskii
2010-11-12 16:47 ` Andreas Schwab
2010-11-12 19:44 ` Miles Bader
2010-11-12 15:48 ` Eli Zaretskii
2010-11-12 17:13 ` Jan D.
2010-11-12 21:15 ` Thien-Thi Nguyen
2010-11-13 19:19 ` Jan Djärv
2010-11-13 19:52 ` Thien-Thi Nguyen
2010-11-13 22:23 ` Jan Djärv
2010-11-13 20:38 ` Johan Bockgård
2010-11-14 10:21 ` Jan Djärv
2010-11-12 18:45 ` Andreas Schwab
2010-11-12 21:00 ` Stefan Monnier
2010-11-15 21:11 ` Julien Danjou
2010-11-15 21:19 ` Andreas Schwab
2010-11-16 5:43 ` Stefan Monnier
2010-11-16 7:56 ` Julien Danjou
2010-11-16 9:05 ` Stephen J. Turnbull
2010-11-16 9:28 ` Julien Danjou
2010-11-16 12:11 ` Stephen J. Turnbull
2010-11-16 15:14 ` Stefan Monnier
2010-11-16 15:38 ` Julien Danjou
2010-11-16 17:05 ` Stefan Monnier
2010-11-16 9:36 ` Andreas Schwab
2010-11-13 20:00 ` Julien Danjou
2010-11-15 16:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sa362w2d3n1.fsf@cigue.easter-eggs.fr \
--to=julien@danjou.info \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.