From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andrea Crotti Newsgroups: gmane.emacs.devel Subject: Re: dired.c Date: Tue, 26 Apr 2011 13:58:30 +0200 Message-ID: References: <5B0C3CF2-85D0-4D68-BFA1-B30B19F8A36C@gmail.com> <4DB50FF2.6060906@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1303819124 11607 80.91.229.12 (26 Apr 2011 11:58:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2011 11:58:44 +0000 (UTC) Cc: Paul Eggert , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 13:58:39 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QEgud-0007ns-E7 for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2011 13:58:39 +0200 Original-Received: from localhost ([::1]:57593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEgua-0006Yl-1W for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2011 07:58:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:44246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEguX-0006Yg-ET for emacs-devel@gnu.org; Tue, 26 Apr 2011 07:58:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEguW-0006lH-F1 for emacs-devel@gnu.org; Tue, 26 Apr 2011 07:58:33 -0400 Original-Received: from mta-2.ms.rz.rwth-aachen.de ([134.130.7.73]:65363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEguW-0006ku-A4 for emacs-devel@gnu.org; Tue, 26 Apr 2011 07:58:32 -0400 Original-Received: from ironport-out-1.rz.rwth-aachen.de ([134.130.5.40]) by mta-2.ms.rz.RWTH-Aachen.de (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008)) with ESMTP id <0LK900JTBD9IHX70@mta-2.ms.rz.RWTH-Aachen.de> for emacs-devel@gnu.org; Tue, 26 Apr 2011 13:58:30 +0200 (CEST) X-IronPort-AV: E=Sophos;i="4.64,268,1301868000"; d="scan'208";a="108585680" Original-Received: from relay-2.ms.rz.rwth-aachen.de (HELO relay.rwth-aachen.de) ([134.130.7.75]) by ironport-in-1.rz.rwth-aachen.de with ESMTP; Tue, 26 Apr 2011 13:58:30 +0200 Original-Received: from plaetekopp (plaetekopp.informatik.RWTH-Aachen.DE [137.226.59.97]) by relay.rwth-aachen.de (8.14.4+Sun/8.13.8/1) with ESMTP id p3QBwUdZ014019; Tue, 26 Apr 2011 13:58:30 +0200 (CEST) Original-Received: from crotti by plaetekopp with local (Exim 4.72) (envelope-from ) id 1QEguU-00051W-4X; Tue, 26 Apr 2011 13:58:30 +0200 In-reply-to: User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 134.130.7.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138779 Archived-At: Stefan Monnier writes: > > Actually, IIUC we could move it all to eval.c. > > > Stefan I just tried out what you suggested and it compiles to me with these changes: (sorry it's not a right bzr patch format I still have to check how to do it) crotti@plaetekopp:~/trunk$ bzr diff src/lisp.h === modified file 'src/lisp.h' --- src/lisp.h 2011-04-15 08:22:34 +0000 +++ src/lisp.h 2011-04-26 11:51:36 +0000 @@ -1966,40 +1966,6 @@ struct handler *next; }; -/* This structure helps implement the `catch' and `throw' control - structure. A struct catchtag contains all the information needed - to restore the state of the interpreter after a non-local jump. - - Handlers for error conditions (represented by `struct handler' - structures) just point to a catch tag to do the cleanup required - for their jumps. - - catchtag structures are chained together in the C calling stack; - the `next' member points to the next outer catchtag. - - A call like (throw TAG VAL) searches for a catchtag whose `tag' - member is TAG, and then unbinds to it. The `val' member is used to - hold VAL while the stack is unwound; `val' is returned as the value - of the catch form. - - All the other members are concerned with restoring the interpreter - state. */ - -struct catchtag -{ - Lisp_Object tag; - Lisp_Object val; - struct catchtag *next; - struct gcpro *gcpro; - jmp_buf jmp; - struct backtrace *backlist; - struct handler *handlerlist; - int lisp_eval_depth; - int pdlcount; - int poll_suppress_count; - int interrupt_input_blocked; - struct byte_stack *byte_stack; -}; extern Lisp_Object memory_signal_data; crotti@plaetekopp:~/trunk$ bzr diff src/dired.c === modified file 'src/dired.c' --- src/dired.c 2011-04-14 19:34:42 +0000 +++ src/dired.c 2011-04-26 11:51:08 +0000 @@ -22,7 +22,7 @@ #include #include #include -#include +/* #include */ #ifdef HAVE_PWD_H #include -- GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2011-03-04 on plaetekopp