* vc-svn-print-log change broke log-view-diff
@ 2007-08-21 18:14 Bernhard Herzog
0 siblings, 0 replies; only message in thread
From: Bernhard Herzog @ 2007-08-21 18:14 UTC (permalink / raw)
To: emacs-devel
Hi,
log-view mode has been broken a little for a while in HEAD when using
SVN. vc-svn-print-log helpfully inserts a line indicating which file
the log is for:
;; Add a line to tell log-view-mode what file this is.
(insert "Working file(s): " (vc-delistify (mapcar 'file-relative-name files)) "\n"))
The problem is the "(s)" which is not matched by the regular expression
in log-view-file-re. As a result log-view-diff fails with the message
Search failed: "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):\\)
The problem was probably introduced by the following commit:
2007-07-18 Eric S. Raymond <esr@snark.thyrsus.com>
* vc-hooks.el: Generalize stay-local-p to operate on lists of
files. Change two keybindings to point to new function names.
* vc-arch.el, vc-bzr.el, vc-cvs.el, vc-hg.el, vc-mcvs.el, vc-rcs.el,
vc-sccs.el, vc-svn.el: These now implement the NewVC-fileset.
* vc.el: Adapted for NewVC-fileset, but no functional changes yet.
Older versions of the file have
(insert "Working file): " [...]
which is matched by log-view-file-re.
Bernhard
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-21 18:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-21 18:14 vc-svn-print-log change broke log-view-diff Bernhard Herzog
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.