From: Bernhard Herzog <bh@intevation.de>
To: emacs-devel@gnu.org
Subject: vc-svn-print-log change broke log-view-diff
Date: Tue, 21 Aug 2007 20:14:25 +0200 [thread overview]
Message-ID: <s9zsl6c69ha.fsf@thoe.hq.intevation.de> (raw)
Hi,
log-view mode has been broken a little for a while in HEAD when using
SVN. vc-svn-print-log helpfully inserts a line indicating which file
the log is for:
;; Add a line to tell log-view-mode what file this is.
(insert "Working file(s): " (vc-delistify (mapcar 'file-relative-name files)) "\n"))
The problem is the "(s)" which is not matched by the regular expression
in log-view-file-re. As a result log-view-diff fails with the message
Search failed: "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):\\)
The problem was probably introduced by the following commit:
2007-07-18 Eric S. Raymond <esr@snark.thyrsus.com>
* vc-hooks.el: Generalize stay-local-p to operate on lists of
files. Change two keybindings to point to new function names.
* vc-arch.el, vc-bzr.el, vc-cvs.el, vc-hg.el, vc-mcvs.el, vc-rcs.el,
vc-sccs.el, vc-svn.el: These now implement the NewVC-fileset.
* vc.el: Adapted for NewVC-fileset, but no functional changes yet.
Older versions of the file have
(insert "Working file): " [...]
which is matched by log-view-file-re.
Bernhard
reply other threads:[~2007-08-21 18:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s9zsl6c69ha.fsf@thoe.hq.intevation.de \
--to=bh@intevation.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.