From: Bernhard Herzog <bh@intevation.de>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Patch to make vc-hg.el work with remote files
Date: Tue, 03 Nov 2009 00:52:43 +0100 [thread overview]
Message-ID: <s9zbpjk8oxg.fsf@thoe.hq.intevation.de> (raw)
In-Reply-To: <200911022158.nA2Lw7eG018645@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 2 Nov 2009 13:58:07 -0800 (PST)")
Dan Nicolaescu <dann@ics.uci.edu> writes:
> Bernhard Herzog <bernhard.herzog@intevation.de> writes:
>
> > On 28.10.2009, Bernhard Herzog wrote:
> > > I've looked a bit closer at it now and AFAICT vc-hg-diff can be made even
> > > simpler and probably more correct by passing files unmodified to
> > > vc-hg-command. I don't have the time right now to test and produce a
> > > better patch, though. I hope to get around to that tomorrow.
> >
> > It took a while longer, but here's the new patch:
>
> Was this tested with filesets that contain: multiple files, multiple
> directories and a mix of files and directories. And starting
> from a subdirectory of the Hg root?
> The previous change caused this regression:
> http://permalink.gmane.org/gmane.emacs.devel/116585
> does this patch fix it?
I've tested various combinations of files and directories from vc-dir
and some commands (e.g. C-c v =) from within a buffer visiting a file
managed by mercurial. They all worked correctly. I may have missed
some cases, though. I was able to reproduce the regression reported in
the mail you referred to, but with my patch it's fixed.
Regards
Bernhard
next prev parent reply other threads:[~2009-11-02 23:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 17:56 Patch to make vc-hg.el work with remote files Bernhard Herzog
2009-10-26 2:00 ` Stefan Monnier
2009-10-27 12:01 ` Bernhard Herzog
2009-10-28 2:07 ` Stefan Monnier
2009-10-28 18:05 ` Bernhard Herzog
2009-11-02 21:34 ` Bernhard Herzog
2009-11-02 21:58 ` Dan Nicolaescu
2009-11-02 23:52 ` Bernhard Herzog [this message]
2009-11-02 22:00 ` Sam Steingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s9zbpjk8oxg.fsf@thoe.hq.intevation.de \
--to=bh@intevation.de \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.