all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mike FABIAN <mfabian@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andreas Schwab <schwab@suse.de>,
	20906@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#20906: 25.0.50;
Date: Fri, 09 Oct 2015 17:34:01 +0200	[thread overview]
Message-ID: <s9doag8rr86.fsf@ari.site> (raw)
In-Reply-To: <s9dh9m1ti21.fsf@ari.site> (Mike FABIAN's message of "Thu, 08 Oct 2015 18:56:54 +0200")

Mike FABIAN <mfabian@redhat.com> さんはかきました:

> Eli Zaretskii <eliz@gnu.org> さんはかきました:
>
>>> From: Andreas Schwab <schwab@suse.de>
>>> Cc: 20906@debbugs.gnu.org,  monnier@iro.umontreal.ca,  mfabian@redhat.com
>>> Date: Thu, 08 Oct 2015 17:33:55 +0200
>>> 
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>> 
>>> >> From: Andreas Schwab <schwab@suse.de>
>>> >> Cc: 20906@debbugs.gnu.org,  monnier@iro.umontreal.ca,  mfabian@redhat.com
>>> >> Date: Thu, 08 Oct 2015 17:08:20 +0200
>>> >> 
>>> >> > So I guess gui-backend-get-selection on x-win.el should loop over the
>>> >> > possible request types, like x-selection-value-internal did in Emacs
>>> >> > 24.5, is that right?
>>> >> 
>>> >> gui--selection-value-internal still does that.
>>> >
>>> > Right, so gui-get-primary-selection should call that instead of
>>> > calling gui-get-selection, I guess?
>>> 
>>> I suppose so, if it wants to be the successor of x-get-selection-value.
>>
>> Mike, can you try that?  Or do you want me to write a patch for you to
>> try?
>
> I can try to write such a patch tomorrow.

This patch according to Andreas’ suggestion does indeed seem to
fix it for me (pasting now always works, from firefox, gtk, xterm, ...):

From 615bf7c7969e79cbdb5a3890ceaed94c84f2111c Mon Sep 17 00:00:00 2001
From: Mike FABIAN <mfabian@redhat.com>
Date: Thu, 8 Oct 2015 15:45:32 +0200
Subject: [PATCH 1/2] In gui-get-primary-selection use
 gui--selection-value-internal (Bug#20906)

* lisp/select.el (gui-get-primary-selection): In gui-get-primary-selection
use gui--selection-value-internal (Bug#20906)
---
 lisp/select.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/select.el b/lisp/select.el
index 74b48d1..2d2ac5f 100644
--- a/lisp/select.el
+++ b/lisp/select.el
@@ -235,7 +235,7 @@ x-get-clipboard
 
 (defun gui-get-primary-selection ()
   "Return the PRIMARY selection, or the best emulation thereof."
-  (or (gui-get-selection 'PRIMARY)
+  (or (gui--selection-value-internal 'PRIMARY)
       (and (fboundp 'w32-get-selection-value)
            (eq (framep (selected-frame)) 'w32)
            ;; MS-Windows emulates PRIMARY in x-get-selection, but only
-- 
2.4.3



-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。





  reply	other threads:[~2015-10-09 15:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 20:35 bug#20906: 25.0.50; Pasting unicode from external applications with mouse wheel on Unix Boris Kheyfets
2015-06-26 21:37 ` Kaushal
2015-06-26 21:41   ` Boris Kheyfets
2015-06-27  7:27     ` Eli Zaretskii
2015-06-27  7:58       ` Boris Kheyfets
2015-06-27  8:12         ` Eli Zaretskii
     [not found]           ` <CADVzOS83fAf1na7ThotyD3mGOJak-U=ZayhGd=cC3=xT2JZuKQ@mail.gmail.com>
2015-06-27  8:33             ` Eli Zaretskii
2015-06-27  8:34             ` Eli Zaretskii
2015-06-27 10:02               ` Boris Kheyfets
2015-06-27 11:44                 ` Eli Zaretskii
2015-10-03 13:15 ` bug#20906: 25.0.50; Mike FABIAN
2015-10-03 14:00   ` Eli Zaretskii
2015-10-05  4:34     ` Mike FABIAN
2015-10-05  6:21       ` Eli Zaretskii
2015-10-05  6:30         ` Mike FABIAN
2015-10-05  7:06           ` Eli Zaretskii
2015-10-05 10:07             ` Mike FABIAN
2015-10-05 10:29               ` Eli Zaretskii
2015-10-05 11:20                 ` Mike FABIAN
2015-10-05 11:39                   ` Eli Zaretskii
2015-10-05 12:04                     ` Andreas Schwab
2015-10-05 12:30                       ` Eli Zaretskii
2015-10-05 15:08                         ` Mike FABIAN
2015-10-05 17:06                           ` Eli Zaretskii
2015-10-06  6:30                             ` Mike FABIAN
2015-10-06 16:29                               ` Eli Zaretskii
2015-10-06 19:44                                 ` Mike FABIAN
2015-10-07  6:35                                   ` Mike FABIAN
2015-10-07 15:33                                     ` Eli Zaretskii
2015-10-08  8:10                                       ` Mike FABIAN
2015-10-08 13:15                                 ` Mike FABIAN
2015-10-08 13:25                                   ` Mike FABIAN
2015-10-08 14:02                                   ` Andreas Schwab
2015-10-08 14:58                                     ` Eli Zaretskii
2015-10-08 15:08                                       ` Andreas Schwab
2015-10-08 15:15                                         ` Eli Zaretskii
2015-10-08 15:33                                           ` Andreas Schwab
2015-10-08 15:42                                             ` Eli Zaretskii
2015-10-08 16:56                                               ` Mike FABIAN
2015-10-09 15:34                                                 ` Mike FABIAN [this message]
2015-10-12  8:39                                                   ` Andreas Schwab
2015-10-12 12:20                                                     ` Mike FABIAN
2015-10-12 15:56                                                       ` Eli Zaretskii
2015-10-05 14:24                       ` Mike FABIAN
2015-10-05 14:55                     ` Mike FABIAN
2015-10-05 15:01                     ` Mike FABIAN
2015-10-05 15:05                     ` Mike FABIAN
2015-10-05 17:05                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s9doag8rr86.fsf@ari.site \
    --to=mfabian@redhat.com \
    --cc=20906@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.