* Re: master 4808c63d43f: Add Tramp method "apptainer"
[not found] ` <20240507075619.C1E19C2BC75@vcs2.savannah.gnu.org>
@ 2024-05-07 14:59 ` Po Lu
2024-05-07 15:34 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2024-05-07 14:59 UTC (permalink / raw)
To: emacs-devel; +Cc: Michael Albinus
Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> branch: master
> commit 4808c63d43f529f41aac2f2bb14df7ab8f882440
> Author: Michael Albinus <michael.albinus@gmx.de>
> Commit: Michael Albinus <michael.albinus@gmx.de>
>
> Add Tramp method "apptainer"
>
> * doc/misc/tramp.texi (Top, Configuration): Add "Optional methods".
> (Optional methods): New section.
> (Inline methods) <androidsu, toolbox, flatpak>: These are optional
> methods.
> (Inline methods) <apptainer>: Add.
>
> * etc/NEWS: New Tramp method "apptainer".
> Some Tramp methods are optional.
> Fix typos.
>
> * lisp/net/tramp-androidsu.el (tramp-enable-androidsu-method):
> New defun. Call it when `system-type' is `android'.
>
> * lisp/net/tramp-container.el (tramp-apptainer-program): New defcustom.
> (tramp-apptainer-method): New defconst.
> (tramp-apptainer--completion-function)
> (tramp-enable-toolbox-method, tramp-enable-flatpak-method)
> (tramp-enable-apptainer-method): New defuns.
>
> * lisp/net/tramp.el (tramp-enable-method): New defun.
>
> * test/lisp/net/tramp-tests.el (tramp--test-container-p):
> Add "apptainer".
> (tramp--test-supports-processes-p): Extend function.
With this change, Tramp ceases to be autoloaded on Android, and when
manually required, signals an error as follows:
byte-code: Recursive load: "/assets/lisp/net/tramp.elc",
"/assets/lisp/net/tramp-androidsu.elc",
"/assets/lisp/net/tramp-loaddefs.elc",
"/assets/lisp/net/tramp-compat.elc", "/assets/lisp/net/tramp.elc",
"/assets/lisp/net/tramp-androidsu.elc",
"/assets/lisp/net/tramp-loaddefs.elc",
"/assets/lisp/net/tramp-compat.elc", "/assets/lisp/net/tramp.elc",
"/assets/lisp/net/tramp-androidsu.elc",
"/assets/lisp/net/tramp-loaddefs.elc",
"/assets/lisp/net/tramp-compat.elc", "/assets/lisp/net/tramp.elc",
"/assets/lisp/net/tramp-androidsu.elc",
"/assets/lisp/net/tramp-loaddefs.elc",
"/assets/lisp/net/tramp-compat.elc", "/assets/lisp/net/tramp.elc"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 4808c63d43f: Add Tramp method "apptainer"
2024-05-07 14:59 ` master 4808c63d43f: Add Tramp method "apptainer" Po Lu
@ 2024-05-07 15:34 ` Michael Albinus
2024-05-07 17:47 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2024-05-07 15:34 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
Po Lu <luangruo@yahoo.com> writes:
Hi,
> With this change, Tramp ceases to be autoloaded on Android, and when
> manually required, signals an error as follows:
Oops. Does this help?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 553 bytes --]
diff --git a/lisp/tramp-androidsu.el b/lisp/tramp-androidsu.el
index 3dcee8e2..09dcd4d7 100644
--- a/lisp/tramp-androidsu.el
+++ b/lisp/tramp-androidsu.el
@@ -94,8 +94,9 @@ may edit files belonging to any and all applications."
`(,tramp-androidsu-method nil ,tramp-root-id-string)))
;;;###tramp-autoload
-(when (eq system-type 'android)
- (tramp-enable-androidsu-method))
+(tramp--with-startup
+ (when (eq system-type 'android)
+ (tramp-enable-androidsu-method)))
(defvar android-use-exec-loader) ; androidfns.c.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: master 4808c63d43f: Add Tramp method "apptainer"
2024-05-07 15:34 ` Michael Albinus
@ 2024-05-07 17:47 ` Michael Albinus
2024-05-07 23:49 ` Po Lu
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2024-05-07 17:47 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Michael Albinus <michael.albinus@gmx.de> writes:
Hi,
>> With this change, Tramp ceases to be autoloaded on Android, and when
>> manually required, signals an error as follows:
>
> Oops. Does this help?
>
> diff --git a/lisp/tramp-androidsu.el b/lisp/tramp-androidsu.el
> index 3dcee8e2..09dcd4d7 100644
> --- a/lisp/tramp-androidsu.el
> +++ b/lisp/tramp-androidsu.el
> @@ -94,8 +94,9 @@ may edit files belonging to any and all applications."
> `(,tramp-androidsu-method nil ,tramp-root-id-string)))
>
> ;;;###tramp-autoload
> -(when (eq system-type 'android)
> - (tramp-enable-androidsu-method))
> +(tramp--with-startup
> + (when (eq system-type 'android)
> + (tramp-enable-androidsu-method)))
>
> (defvar android-use-exec-loader) ; androidfns.c.
I could reproduce the problem locally. The proposed fix cures it, so I
have pushed it to master.
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 4808c63d43f: Add Tramp method "apptainer"
2024-05-07 17:47 ` Michael Albinus
@ 2024-05-07 23:49 ` Po Lu
0 siblings, 0 replies; 4+ messages in thread
From: Po Lu @ 2024-05-07 23:49 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
Michael Albinus <michael.albinus@gmx.de> writes:
> Michael Albinus <michael.albinus@gmx.de> writes:
>
> Hi,
>
>>> With this change, Tramp ceases to be autoloaded on Android, and
>>> when
>>> manually required, signals an error as follows:
>>
>> Oops. Does this help?
>>
>> diff --git a/lisp/tramp-androidsu.el b/lisp/tramp-androidsu.el
>> index 3dcee8e2..09dcd4d7 100644
>> --- a/lisp/tramp-androidsu.el
>> +++ b/lisp/tramp-androidsu.el
>> @@ -94,8 +94,9 @@ may edit files belonging to any and all applications."
>> `(,tramp-androidsu-method nil ,tramp-root-id-string)))
>>
>> ;;;###tramp-autoload
>> -(when (eq system-type 'android)
>> - (tramp-enable-androidsu-method))
>> +(tramp--with-startup
>> + (when (eq system-type 'android)
>> + (tramp-enable-androidsu-method)))
>>
>> (defvar android-use-exec-loader) ; androidfns.c.
>
> I could reproduce the problem locally. The proposed fix cures it, so I
> have pushed it to master.
>
> Best regards, Michael.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-07 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171506857890.22154.1102080900890818821@vcs2.savannah.gnu.org>
[not found] ` <20240507075619.C1E19C2BC75@vcs2.savannah.gnu.org>
2024-05-07 14:59 ` master 4808c63d43f: Add Tramp method "apptainer" Po Lu
2024-05-07 15:34 ` Michael Albinus
2024-05-07 17:47 ` Michael Albinus
2024-05-07 23:49 ` Po Lu
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.