all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Bug: ox-html.el does not take into consideration #+attr_html during table export [7.9.3e (7.9.3e-956-g3943be.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)]
@ 2013-02-14  9:42 Дядов Васил Стоянов
  2013-02-14 10:08 ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: Дядов Васил Стоянов @ 2013-02-14  9:42 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Patch with fix attached.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ox-html.el.patch --]
[-- Type: text/x-patch, Size: 644 bytes --]

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 743f465..797aa96 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -2674,8 +2674,10 @@ contextual information."
            (table-attributes
             (let ((table-tag (plist-get info :html-table-tag)))
               (concat
+                (if (string-equal attributes "")
                (and (string-match  "<table\\(.*\\)>" table-tag)
                     (match-string 1 table-tag))
+                  attributes)
                (and label (format " id=\"%s\""
                                   (org-export-solidify-link-text label)))))))
        ;; Remove last blank line.

[-- Attachment #3: Type: text/plain, Size: 224 bytes --]



Emacs  : GNU Emacs 24.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.9)
 of 2012-12-25 on canopus-pc.elvees.com
Package: Org-mode version 7.9.3e (7.9.3e-956-g3943be.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Bug: ox-html.el does not take into consideration #+attr_html during table export [7.9.3e (7.9.3e-956-g3943be.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)]
  2013-02-14  9:42 Bug: ox-html.el does not take into consideration #+attr_html during table export [7.9.3e (7.9.3e-956-g3943be.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)] Дядов Васил Стоянов
@ 2013-02-14 10:08 ` Bastien
  2013-02-14 12:30   ` Links in tables and org-return-follows-link Дядов Васил Стоянов
  0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2013-02-14 10:08 UTC (permalink / raw)
  To: Дядов Васил Стоянов
  Cc: emacs-orgmode

Thanks for reporting this and for the patch.

I've applied a different patch, which appends attributes to the
default ones, which is what most users expect IMHO.

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Links in tables and org-return-follows-link
  2013-02-14 10:08 ` Bastien
@ 2013-02-14 12:30   ` Дядов Васил Стоянов
  2013-02-15 15:45     ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: Дядов Васил Стоянов @ 2013-02-14 12:30 UTC (permalink / raw)
  To: emacs-orgmode


Hi!

When I set variable org-return-follows-link to true I expect that it
will work on links in tables too (when org-table-editor is on). But
it does not.

Is it wrong behaviour of org-mode?

With best regards,
Vasil

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Links in tables and org-return-follows-link
  2013-02-14 12:30   ` Links in tables and org-return-follows-link Дядов Васил Стоянов
@ 2013-02-15 15:45     ` Bastien
  2013-02-18 13:21       ` Дядов Васил Стоянов
  0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2013-02-15 15:45 UTC (permalink / raw)
  To: Дядов Васил Стоянов
  Cc: emacs-orgmode

Hi Vasil,

vdyadov@elvees.com (Дядов Васил Стоянов) writes:

> When I set variable org-return-follows-link to true I expect that it
> will work on links in tables too (when org-table-editor is on). But
> it does not.
>
> Is it wrong behaviour of org-mode?

The behavior of RET in tables takes precedence in this case,
which is the right thing to do IMO.

You need to open the link at point with C-c C-o in tables.

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Links in tables and org-return-follows-link
  2013-02-15 15:45     ` Bastien
@ 2013-02-18 13:21       ` Дядов Васил Стоянов
  0 siblings, 0 replies; 5+ messages in thread
From: Дядов Васил Стоянов @ 2013-02-18 13:21 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode


Hi Bastien,

Bastien <bzg@altern.org> writes:

>> When I set variable org-return-follows-link to true I expect that it
>> will work on links in tables too (when org-table-editor is on). But
>> it does not.
>>
>> Is it wrong behaviour of org-mode?
>
> The behavior of RET in tables takes precedence in this case,
> which is the right thing to do IMO.
>
> You need to open the link at point with C-c C-o in tables.

Thanks for clarification!


With best regards,

Vasil

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-02-18 14:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-14  9:42 Bug: ox-html.el does not take into consideration #+attr_html during table export [7.9.3e (7.9.3e-956-g3943be.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)] Дядов Васил Стоянов
2013-02-14 10:08 ` Bastien
2013-02-14 12:30   ` Links in tables and org-return-follows-link Дядов Васил Стоянов
2013-02-15 15:45     ` Bastien
2013-02-18 13:21       ` Дядов Васил Стоянов

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.