From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108098: * admin/bzrmerge.el (bzrmerge-resolve): Disable local eval:. Date: Fri, 10 Aug 2012 11:51:59 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1344613933 28620 80.91.229.3 (10 Aug 2012 15:52:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2012 15:52:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 17:52:13 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SzrVS-0007FG-LU for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2012 17:52:10 +0200 Original-Received: from localhost ([::1]:42878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzrVR-0003Y4-Ug for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2012 11:52:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzrVM-0003Xb-If for emacs-devel@gnu.org; Fri, 10 Aug 2012 11:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzrVJ-0002aJ-R6 for emacs-devel@gnu.org; Fri, 10 Aug 2012 11:52:04 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:34306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzrVJ-0002aF-Nx for emacs-devel@gnu.org; Fri, 10 Aug 2012 11:52:01 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SzrVH-00034W-R8; Fri, 10 Aug 2012 11:51:59 -0400 X-Spook: bootleg ANC Ft. Bragg blackjack Ortega Vickie Weaver FBI X-Ran: LW#:nTwlxh=?R\i5=t!|hA^1,?4(2K23Mn7>?alVmATg-asm{oJ4lgiR5Y=NUg%j45iH@0 X-Hue: cyan X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Fri, 10 Aug 2012 11:26:50 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152415 Archived-At: Stefan Monnier wrote: >> - (with-current-buffer (let ((enable-local-variables :safe)) >> + (with-current-buffer (let ((enable-local-variables :safe) >> + (enable-local-eval nil)) > > Why are those changes needed? Paranoia. > Shouldn't (enable-local-variables :safe) be sufficient? Yes. Unless there is another screw-up like http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12155 BTW, there have been zero other comments on that. Emacs releases have happened in similar cases in the past, IIUC.