From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65193: 29.1.50; SET_FRAME_ICONIFIED can cause Lisp evaluation inside read_socket_hook. Date: Fri, 11 Aug 2023 08:02:28 +0800 Message-ID: References: <87pm3vs3qf.fsf@yahoo.com> <87zg2zqcbg.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28897"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65193@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 11 02:03:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUFch-0007Ju-4Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Aug 2023 02:03:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUFcQ-0001Vj-GN; Thu, 10 Aug 2023 20:03:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUFcN-0001U0-W3 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 20:03:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUFcM-0006bi-77 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 20:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUFcM-00066h-1T for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 20:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2023 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65193 X-GNU-PR-Package: emacs Original-Received: via spool by 65193-submit@debbugs.gnu.org id=B65193.169171217223460 (code B ref 65193); Fri, 11 Aug 2023 00:03:02 +0000 Original-Received: (at 65193) by debbugs.gnu.org; 11 Aug 2023 00:02:52 +0000 Original-Received: from localhost ([127.0.0.1]:44295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUFcC-00066K-EZ for submit@debbugs.gnu.org; Thu, 10 Aug 2023 20:02:52 -0400 Original-Received: from sonic317-33.consmr.mail.ne1.yahoo.com ([66.163.184.44]:43116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUFc9-000666-Ew for 65193@debbugs.gnu.org; Thu, 10 Aug 2023 20:02:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691712163; bh=oo18n5RyOjIo9bfe8DSs1Kx758Z3sIDeUWIx2dwahIw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=kyLQJiP9eDk5RdHo1WL7K1Bg84nN6EiwNni8YIT4w1B/EHiLMv3usvaoWjmfEkvWafoAZ4eIg/19xspIE3BQ3JRSNGFMP8YAOXLNxOo7dVyYyZysMM67hytwOmyXmvawZuEMIbN1soiwzS9ECbsYkMSM+Qao4ZDG0FEE0amRdrQdRWM8mAeo6dFO3hOhFLuAZiH5wP+EbSy/aWMnyIWRsDsY4i38/BwEpqWeAao8hbU/4+1kiv/BEpWeYdouQjO338Tve967sCuwvdY0jnLIsVoDT7tYESn+3BJCj+hMll2SWnJYzhaH+ayouZRXcZ/OtDIR1jPZQG1WoBAMbzHdxQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691712163; bh=5DpJNvzTVBl9IFNPPpE3hspBSVCwr+w9dco7Z/0JJPt=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=MdZJQI8wlqSo0P6w3j0i6WA3BRURrGDO8hSOXMJ1v0Y6fon9BUJb8YmDtLXVCO/dUnceeREtBSBu6n/RAOIJRXavLoZPKnhFoyFbULHHidU0pvHIcfUWRezIUU886oPxFoultPPWTPZrVQNPds0NQImkGKEEy9UrXX+6qM5iJa7ZpkeRHrZMiZogytWPMBgw7wahwG41SCD0ssFHXVIgWtwHz2dUdcdZYA7D+/dnNc9Eax9/yYF6LrectGiiZ96S7O8Vgk7NIK+HtDci1ao2p/Km1Q+4fpS79OHfP0IZzCOvQvAMU6Q6ymrwxY2SZw+3d4k7t91w4WYZNlwwQ2t4lQ== X-YMail-OSG: iYfJBGoVM1n1fZbHw1asXWKZuis3o.roBd6sFTZMuNdA7bOnLhdGUc3aEb7ww2o IoEOl_KwOrG8UdcjhxJXTU_LCHfXgOQQ4BS2_DtYtHGJoLtwZJkyejpsH9Ywz2VrwqpPoJc.kONz hDGnfPV06Lz.edbSyFHH6b0wo2lhmdVR9ccYlZvpOEIjPID61aQPxm6kCY1w3PEPNvbpkpTiRrbB C4EonwMjxpEBKFP108NJZZiMrObxBqdbI8xRAirfAjhLLvcpPysvF7gewryC2O9HxFn88lGdrJG. MB4Kj1.VNI_vaUQcBoYzPPHmRL3V7vi43KYb6uCXHb9V99tGZpHQpcIfg4dVZPERJUoYm_O4bekL QEnxjTCKmQH02Nxt4cNNljvro.kLj4myIbHza__.5iRIu6CtcfUzazpe3yMFsKI14fqh0zovaZHr I7_h9DZk31xXKOtfjB3vD6FzA0bihfyarY6h4Jz1D4MxsWsW5N58E3Ux1UPBCuKaL43soiJdY9mk 2i28cH9k3skImk1aUL4f0nUqscgQxPTeW9bVXDJGJ74PHDDQw_wPCqHA2CCjWUfjwY34gJRNk_5p cZWN5D9sDKGtY8l4SIFiZEAiOUsvM68mHs_Rl7qMACYwJ1c9sQCUbP7m4TtHf0wdep1YJRDzkVlq 6JEmeknAdrTc8JZjkbtPZyle2g1W2u5qbEOf9O2ZWKpPI3b6WiID9HZszWKXpLutKZNTaOPY9C8G ccCVXs4NEoWYEQ4hvfUlRsUmMQQi3Be0PzwN6sT_AlykClHOnLisM60kmev574opzbVQR8peEUU5 cs_ijGPJpjR_HwUAWTGZrvyj28wailevJ8ycuenbko X-Sonic-MF: X-Sonic-ID: a2490dbc-36d9-4261-9b9d-a597e84bffaa Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 11 Aug 2023 00:02:43 +0000 Original-Received: by hermes--production-sg3-69654d8bd-sbrjf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 963282e6395d49c9165aeeb68ce95793; Fri, 11 Aug 2023 00:02:38 +0000 (UTC) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Fri, 11 Aug 2023 01:32:47 +0900") X-Mailer: WebService/1.1.21695 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267170 Archived-At: YAMAMOTO Mitsuharu writes: > What made Lisp evaluation inside read_socket_hook possible since then? I don't know, but we've done it since then without problems. > At least it can cause some corruption/inconsistency unless every > unblock_input/maybe_quit takes account of potential GC (including > string compaction). Long-standing code would originally be written > without such a consideration. Is it already audited thoroughly? Can you find any code which saves pointers to string data or buffer text around calls to functions that might read input? > Since which version? I don't know. > Probably the possibility of encountering the problem would be quite > low and even if it happens, it is really difficult to reproduce, let > alone to identify the root cause. To the best of my knowledge, this is only a problem for the NS port. Since other ports don't read input from their select emulations. That is no great loss, given that the toolkit aborts after the first call to redisplay from outside the main thread, so threads don't work under NS anyway.