From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Dave Love <d.love@dl.ac.uk>
Newsgroups: gmane.emacs.devel
Subject: Re: enhanced select-safe-coding-system
Date: 04 May 2002 23:56:40 +0100
Sender: emacs-devel-admin@gnu.org
Message-ID: <rzqd6wb1pzr.fsf@djlvig.dl.ac.uk>
References: <rzqk7qp2log.fsf@djlvig.dl.ac.uk>
	<200205010714.g417Eq607434@aztec.santafe.edu>
	<rzqlmb22myp.fsf@djlvig.dl.ac.uk>
	<200205031327.g43DR1014311@rum.cs.yale.edu>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1020553044 25775 127.0.0.1 (4 May 2002 22:57:24 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sat, 4 May 2002 22:57:24 +0000 (UTC)
Cc: rms@gnu.org,  emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 1748Sy-0006hb-00
	for <emacs-devel@main.gmane.org>; Sun, 05 May 2002 00:57:24 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 1748ZM-0004Va-00
	for <emacs-devel@quimby.gnus.org>; Sun, 05 May 2002 01:04:01 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 1748Se-0006Sh-00; Sat, 04 May 2002 18:57:04 -0400
Original-Received: from djlvig.dl.ac.uk ([148.79.112.146])
	by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian))
	id 1748SP-0006S9-00; Sat, 04 May 2002 18:56:49 -0400
Original-Received: from fx by djlvig.dl.ac.uk with local (Exim 3.12 #1 (Debian))
	id 1748SH-0006CN-00; Sat, 04 May 2002 23:56:41 +0100
Original-To: "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu>
X-Face: "_!nmR@11ZNuumt0oqG"Y3Hfy|;FGz)`"ul[G?ah6k-oNyDW?3/Nq3Qab$kUnUQ_d4};kPl
 R=}-Vqfo|S5mThi-k<sb8dDL76.\(='H$ee]<E5E=}pX[X&;]RITcPw-6GDeIlbJlshHd~p1Ip&xZE
 [dYv$`;'AXF-OV$@6dcl/*rvO{8a~`_Qq2FJZx>aBR=>%g5a3-OvnEhdHu{^APIaP:b}0m!$bDC>SX
 zz'r)e?`at?tpD*+~b+pf
Original-Lines: 24
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1.95
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.9
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:3588
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3588

"Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu> writes:

> I have recently posted a fairly simple patch that does that by slightly
> modifying the C code, so it's fast.

How is that?  I think the Lisp is actually fast enough in that
application on a P100.  I included the warning in case anyone used it
without checking.

Anyway, be careful.  As far as I can tell, find-coding-systems-region
should remain the basic operation for this sort of thing and you need
to beware of confusion and maintenance issues from providing
alternative functionality.  (Look at Gnus as an example of confusion
in this area.)

> The only question is if such
> a functionality is good enough to efficiently implement Emacs-20's behavior
> (which was to highlight the offending chars, rather than just jump to the
> first one)

I think what's most important is to be able to get information on the
first one (at point) more than to have them all highlighted.  That's
usually enough to figure out what the encoding problem is, not that
extra information would hurt, obviously.