From: Glenn Morris <rgm@gnu.org>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: 15745@debbugs.gnu.org
Subject: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface
Date: Mon, 28 Oct 2013 22:29:57 -0400 [thread overview]
Message-ID: <rs61sgvmfu.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAFM41H1RMRVMpvnRiJzPG0Yu3eB4KaX-h5MuepfbuqXWbbeQow@mail.gmail.com>
Barry OReilly wrote:
> Thanks, how is the attached revised patch?
Not quite what I had in mind (taking something that was a variable and
turning it into a face alias won't work right, will it?).
-(defvar semantic-idle-symbol-highlight-face 'region
- "Face used for highlighting local symbols.")
+(defface semantic-idle-symbol-highlight
+ '((((class color) (background dark))
+ ;; Put this back to something closer to black later.
+ (:background "gray20"))
+ (((class color) (background light))
+ (:background "gray90")))
+ "Face used for highlighting local symbols."
+ :group 'semantic-faces)
As has been said:
(defface semantic-idle-symbol-highlight '((t (:inherit region))) ...)
+(define-obsolete-face-alias
+ 'semantic-idle-symbol-highlight-face
+ 'semantic-idle-symbol-highlight
+ "24.4")
Rather than the above, I meant:
(make-obsolete-variable 'semantic-idle-symbol-highlight-face
"customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set)
Then these bits:
- region semantic-idle-symbol-highlight-face)
+ region 'semantic-idle-symbol-highlight)
are not necessary (or appropriate).
next prev parent reply other threads:[~2013-10-29 2:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 21:04 bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface Barry OReilly
2013-10-28 21:38 ` Glenn Morris
2013-10-28 22:36 ` Barry OReilly
2013-10-29 2:29 ` Glenn Morris [this message]
2013-10-29 15:56 ` Barry OReilly
2013-10-29 22:37 ` Glenn Morris
2013-10-31 1:55 ` Barry OReilly
2013-10-29 1:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rs61sgvmfu.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=15745@debbugs.gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.