From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#14169: vc: [bzr] Small nuissance when invoking 'log-view-diff-changeset' Date: Wed, 24 Apr 2013 21:47:08 -0400 Message-ID: References: <87bo9nxyc1.fsf@fimbulvetr.bsc.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1366854485 9906 80.91.229.3 (25 Apr 2013 01:48:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Apr 2013 01:48:05 +0000 (UTC) Cc: 14169@debbugs.gnu.org To: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 03:48:03 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UVBI3-0002by-Bz for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2013 03:48:03 +0200 Original-Received: from localhost ([::1]:54921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBI2-0003Lc-V8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 21:48:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBHy-0003Kz-PP for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 21:47:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVBHx-0002i2-TF for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 21:47:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBHx-0002hu-Pw for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 21:47:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UVBMs-0001aH-Gm for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 21:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2013 01:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14169-submit@debbugs.gnu.org id=B14169.13668547375942 (code B ref 14169); Thu, 25 Apr 2013 01:53:02 +0000 Original-Received: (at 14169) by debbugs.gnu.org; 25 Apr 2013 01:52:17 +0000 Original-Received: from localhost ([127.0.0.1]:41933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UVBM8-0001Xn-OW for submit@debbugs.gnu.org; Wed, 24 Apr 2013 21:52:17 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:40603) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UVBM6-0001Xe-LS for 14169@debbugs.gnu.org; Wed, 24 Apr 2013 21:52:15 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UVBHA-0000Gg-Ai; Wed, 24 Apr 2013 21:47:08 -0400 X-Spook: weapons of mass destruction Mole Saudi Arabia Crowell X-Ran: !`dga0>>on46XCmXqep{Pt+}$iA:))7ey`z?i;Ho(c[BZ[,znp:6Dxi9D:yd(Fb9|<:;#L X-Hue: red X-Attribution: GM In-Reply-To: <87bo9nxyc1.fsf@fimbulvetr.bsc.es> ("=?UTF-8?Q?Llu=C3=ADs?= Vilanova"'s message of "Tue, 09 Apr 2013 22:07:10 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73658 Archived-At: Llu=C3=ADs Vilanova wrote: > When issuing 'vc-print-log', the results of "bzr log" have a line of '-' > characters prepended to every revision. > > The net result is that point is set to the first line of the output, > which is a line with '-' characters, and 'log-view-diff-changeset' is > unable to show the diff for that line. There's two issues here. svn also has ----- lines, yet vc-print-log manages to move point to the line with the first revision number on. When visiting a file under SVN, we manage to set the working revision to the last revision in which that file was modified. See comment in vc-svn-parse-status: ;; Use the last-modified revision, so that searching in vc-print-log ;; output works. vc-print-log is able to move point to this revision. With bzr, the only revision number we can get is the one in which the repository was last modified. If the file in question was not modified in this revision, vc-print-log doesn't find that revision and so leaves point at point-min. I don't think there is any bzr fix for this. > It also feels inconsistent that hitting 'D' on any other line of '-' > characters shows the diff for the previous revision (while that line > is, in fact, a prefix for the revision that comes below). (Same issue for svn. svn also fails if you move to the first line of the buffer.) The second issue is that log-view-current-entry assumes that the revision number is always on the first line of a log entry. It finds revisions by doing (forward-line 1), then searching backwards for log-view-message-re. This can miss revisions. Maybe it could instead first search forwards, then backwards. =20