From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Per Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Customizing key bindings (was: Re: [CVS] f7, f8 bound..) Date: Mon, 09 Sep 2002 09:57:46 +0200 Organization: The Church of Emacs Sender: emacs-devel-admin@gnu.org Message-ID: References: <200208271621.g7RGLNm30516@rum.cs.yale.edu> <5xhehfe3aj.fsf@kfs2.cua.dk> <874rdfaytt.fsf@pot.cnuce.cnr.it> <5xvg5sh06u.fsf@kfs2.cua.dk> <20020830235528.GA13207@gnu.org> <87ofbji88u.fsf@emacswiki.org> <87sn0scb0b.fsf@emacswiki.org> <87bs7ama8g.fsf@emacswiki.org> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1031558415 29794 127.0.0.1 (9 Sep 2002 08:00:15 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 9 Sep 2002 08:00:15 +0000 (UTC) Cc: alex@emacswiki.org, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17oJSw-0007kQ-00 for ; Mon, 09 Sep 2002 10:00:14 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17oK2m-0003Ky-00 for ; Mon, 09 Sep 2002 10:37:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oJSy-0003ct-00; Mon, 09 Sep 2002 04:00:16 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17oJRB-0003Jx-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 03:58:25 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17oJR9-0003Io-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 03:58:24 -0400 Original-Received: from sheridan.dina.kvl.dk ([130.225.40.227]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oJR7-0003IM-00; Mon, 09 Sep 2002 03:58:21 -0400 Original-Received: from zuse.dina.kvl.dk (zuse.dina.kvl.dk [130.225.40.245]) by sheridan.dina.kvl.dk (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id JAA17215; Mon, 9 Sep 2002 09:57:52 +0200 Original-Received: (from abraham@localhost) by zuse.dina.kvl.dk (8.9.3+Sun/8.9.3) id JAA26357; Mon, 9 Sep 2002 09:57:46 +0200 (MEST) X-Authentication-Warning: zuse.dina.kvl.dk: abraham set sender to abraham@dina.kvl.dk using -f Original-To: rms@gnu.org X-Face: +kRV2]2q}lixHkE{U)mY#+6]{AH=yN~S9@IFiOa@X6?GM|8MBp/ In-Reply-To: (Richard Stallman's message of "Sun, 08 Sep 2002 08:54:33 -0400") Original-Lines: 35 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.1 (sparc-sun-solaris2.8) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7734 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7734 Richard Stallman writes: > It looks basically good now. > > (defvar custom-global-keymap (let ((map (make-sparse-keymap))) > (set-keymap-parent map global-map) > map) > > It looks like that is no longer used for anything. Is it obsolete? Yes, totally. > (defmacro defkeymap (symbol map doc &rest args) > "Define SYMBOL to be a keymap with value MAP. > DOC is the keymap documentation." > ;; It is better not to use backquote in this file, > ;; because that makes a bootstrapping problem > ;; if you need to recompile all the Lisp files using interpreted code. > (nconc (list 'custom-declare-keymap > (list 'quote symbol) > (list 'quote map) > doc) > args)) > > It would be better to generate a defvar plus whatever other stuff > you need. I prefer doing most of the work in functions rather than macros, because if we change defkeymap in Emacs version X+1, then packages compiled by the user in Emacs version X will call the new function, and thus continue to work. I had a lot of such problems with easymenu.el. It seems likely that we may want to change 'custom-declare-keymap' after getting experience from a release, so this is a real concern.