bug#18482: 24.4.50; msb-mode error

bug#18482: 24.4.50; msb-mode error

[Dieter Faulbaum]

When msb-mode is switched on selecting another buffer gives this error:

command-execute: Wrong type argument: commandp, ((nil) . menu-bar-select-buffer)



In GNU Emacs 24.4.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2014-09-15 on alder
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux 7.6 (wheezy)

Configured using:
 `configure --prefix=/opt/emacs-snapshot'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LC_COLLATE: C
  value of $LC_TIME: de_DE.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<help-echo> M-x e m a <tab> b <tab> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> - b u <tab> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
r e p o <tab> r t <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 75697 7698)
 (symbols 48 17958 0)
 (miscs 40 39 114)
 (strings 32 10471 4595)
 (string-bytes 1 290566)
 (vectors 16 9350)
 (vector-slots 8 386227 17096)
 (floats 8 70 172)
 (intervals 56 201 0)
 (buffers 976 12)
 (heap 1024 28232 629))

bug#18482: 24.4.50; msb-mode error

[Glenn Morris]

Dieter Faulbaum wrote:

> When msb-mode is switched on selecting another buffer gives this error:
>
> command-execute: Wrong type argument: commandp, ((nil) . menu-bar-select-buffer)

Sounds like the same root cause as http://debbugs.gnu.org/18016 .

So probably the same kind of change will fix it, but are the r117463
simplification changes still desirable in light of this?
(Also, they don't seem to have a NEWS entry.)

bug#18482: 24.4.50; msb-mode error

[Stefan Monnier]

>> When msb-mode is switched on selecting another buffer gives this error:
>> command-execute: Wrong type argument: commandp, ((nil)
>> . menu-bar-select-buffer)
> Sounds like the same root cause as http://debbugs.gnu.org/18016 .

Indeed.  Should be fixed now.

> So probably the same kind of change will fix it, but are the r117463
> simplification changes still desirable in light of this?

This shortcut cache has been announced as obsolete for a while, so
I think it's OK to remove it.

> (Also, they don't seem to have a NEWS entry.)

Indeed, I didn't expect to need to mention it in the NEWS, but
experience shows it deserves to be there.


        Stefan

bug#18482: 24.4.50; msb-mode error

[Glenn Morris]

Stefan Monnier wrote:

> This shortcut cache has been announced as obsolete for a while, so

Is that

    "The menu bar bindings's caches are not used any more."

?

bug#18482: 24.4.50; msb-mode error

[Glenn Morris]

>> This shortcut cache has been announced as obsolete for a while, so

PS announcing the obsolescence obviously didn't prompt us to remove any
(?) of the uses in Emacs itself, so why expect external packages to do
better? ;)

bug#18482: 24.4.50; msb-mode error

[Stefan Monnier]

>>> This shortcut cache has been announced as obsolete for a while, so
> PS announcing the obsolescence obviously didn't prompt us to remove any
> (?) of the uses in Emacs itself, so why expect external packages to do
> better? ;)

It's extremely unusual to put those in manually.


        Stefan