From: Glenn Morris <gmorris+emacs@ast.cam.ac.uk>
Cc: emacs-devel@gnu.org
Subject: Re: [salve@debian.org: lisp/mail/supercite.el: sc-select-attribution logic is broken (patch included)]
Date: Thu, 26 May 2005 18:21:19 +0100 [thread overview]
Message-ID: <r6br6xnbsg.fsf@xpc14.ast.cam.ac.uk> (raw)
In-Reply-To: <E1DaxOl-0007tz-W5@fencepost.gnu.org> (Richard Stallman's message of "Wed, 25 May 2005 11:02:19 -0400")
Richard Stallman wrote:
> Is there someone here who can evaluate this proposed patch?
> I don't use supercite.
I used to use supercite. I think the complaint is correct, but the
patch
> - --- lisp/mail/supercite.el 2005-04-04 11:19:51.000000000 +0200
> +++ lisp/mail/supercite-dgms.el 2005-05-09 13:30:56.000000000 +0200
> @@ -1174,8 +1174,9 @@
> (setq attribution attrib
> attriblist nil))
> ((listp attrib)
> - - (setq attribution (eval attrib)
> - - attriblist nil))
> + (setq attribution (eval attrib))
> + (when attribution
> + (setq attriblist nil))
> (t (error "%s did not evaluate to a string or list!"
> "sc-attrib-selection-list"))
> )))
is wrong since it leads to an infinite loop when (eval attrib) returns
nil. I suggest the following:
diff -c -c -w -r1.44 supercite.el
*** supercite.el 14 May 2005 11:27:40 -0000 1.44
--- supercite.el 26 May 2005 17:15:39 -0000
***************
*** 1183,1189 ****
attriblist nil))
((listp attrib)
(setq attribution (eval attrib)
! attriblist nil))
(t (error "%s did not evaluate to a string or list!"
"sc-attrib-selection-list"))
)))
--- 1183,1190 ----
attriblist nil))
((listp attrib)
(setq attribution (eval attrib)
! attriblist (if (stringp attribution) nil
! (cdr attriblist))))
(t (error "%s did not evaluate to a string or list!"
"sc-attrib-selection-list"))
)))
next prev parent reply other threads:[~2005-05-26 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 15:02 [salve@debian.org: lisp/mail/supercite.el: sc-select-attribution logic is broken (patch included)] Richard Stallman
2005-05-26 17:21 ` Glenn Morris [this message]
2005-05-27 14:18 ` Richard Stallman
2005-05-30 11:57 ` Glenn Morris
2005-05-26 17:32 ` Glenn Morris
-- strict thread matches above, loose matches on Subject: below --
2005-05-11 16:25 Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r6br6xnbsg.fsf@xpc14.ast.cam.ac.uk \
--to=gmorris+emacs@ast.cam.ac.uk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.