all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Bastien <bzg@altern.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: New custom faces for rmail.el
Date: Tue, 12 Feb 2008 00:46:20 -0500	[thread overview]
Message-ID: <r1abm6sp5f.fsf@fencepost.gnu.org> (raw)
In-Reply-To: 87d4r23j4p.fsf@bzg.ath.cx

Bastien wrote:

> +(defface rmail-header-name-face
> +  '((t (:inherit font-lock-function-name-face)))
> +  "Face to use for highlighting the header names."
> +  :group 'rmail-headers
> +  :version "22.1")

"23.1"

Face names should not end in -face.

> +(defcustom rmail-header-name 'rmail-header-name-face "\
> +*Face to use for highlighting the header names."
> +  :type '(choice (const :tag "Default" nil)
> +		 face)
> +  :group 'rmail-headers)

There's no need for a variable, just the face is enough.




  reply	other threads:[~2008-02-12  5:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 21:55 New custom faces for rmail.el Bastien Guerry
2008-02-12  3:51 ` Richard Stallman
2008-02-12  4:15   ` Bastien
2008-02-12  5:46     ` Glenn Morris [this message]
2008-02-12  6:49       ` Bastien Guerry
2008-02-12  6:53         ` Miles Bader
2008-02-12  7:26           ` Bastien Guerry
2008-02-13  2:00             ` Xavier Maillard
2008-02-13 10:15               ` Andreas Schwab
2008-02-14  2:00                 ` Xavier Maillard
2008-02-13 21:15               ` OT: A non-text attachment was scrubbed... (was: New custom faces for rmail.el) Reiner Steib
2008-02-13 22:05             ` New custom faces for rmail.el Bastien Guerry
2008-02-12 13:21         ` Stefan Monnier
2008-02-12 13:24           ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=r1abm6sp5f.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=bzg@altern.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.