From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] feature/byte-switch 086c4ea: * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch Date: Fri, 20 Jan 2017 01:10:02 -0800 Message-ID: References: <20170118171311.10996.72260@vcs.savannah.gnu.org> <20170118171311.A84EA220125@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484903444 30652 195.159.176.226 (20 Jan 2017 09:10:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2017 09:10:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Vibhav Pant , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 20 10:10:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUVDA-0005yz-Bm for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2017 10:10:20 +0100 Original-Received: from localhost ([::1]:53234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUVDD-0001zF-Nj for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2017 04:10:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUVD4-0001yy-Uj for emacs-devel@gnu.org; Fri, 20 Jan 2017 04:10:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUVCz-00010c-WB for emacs-devel@gnu.org; Fri, 20 Jan 2017 04:10:14 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:47020) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cUVCz-0000zx-Po for emacs-devel@gnu.org; Fri, 20 Jan 2017 04:10:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=8xT7ZS5C5Mkup8bttNdJJtNlS6fCTs4hjwu5lbdVOeU=; b=EUfXMo6lP/znKCDvB8RqkhAXo5fdcUe6bG9EXON8VpR85cjQjEJEvvlciu7RW/B6HQcqVHMjbvVxsns31vOOBQBkIMBJy0RukK+vbaJWWIUCpdlDPO8e9StR1U3k5XhNeyiuqjiuWzTFup2R/duLgNvY7zXqULsohrRDi3BJvnAcIWJ7aGWs8vdXm3pXj8bOLHFzTr9dbEtraafDFsYAmTXWlbrfTOG3RzkxhGBX7gzkqgU9C7j3tIP4ul2OghxS9kK762Lb0bj7KxZqwjLEB5otAtEhq20vPIWbCZ14jayuZRSZvdaQbNuMX+FT239sd8e0bkfWSAWOH4zwgMmZ+w==; Original-Received: from c-73-140-245-253.hsd1.wa.comcast.net ([73.140.245.253] helo=thule.roam.corp.google.com) by dancol.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1cUVCw-0004Wj-Ph; Fri, 20 Jan 2017 01:10:06 -0800 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Jan 2017 12:48:53 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211421 Archived-At: On Wed, Jan 18 2017, Stefan Monnier wrote: >> * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch >> Fgethash type checks the provided table object, which is unnecessary >> for compiled bytecode. > > While it's true that we can cause a core dump of Emacs if we feed it an > invalid .elc file, that's a "feature" I'd rather shrink rather > than generalize. Why? If anything, the opposite direction is the right one. elc files should be tightly coupled to the Emacs that built them so that they can be specialized for specific machines. You could imagine them containing, say, saved JIT traces.