From: Daniel Colascione <dancol@dancol.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Vibhav Pant <vibhavp@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] feature/byte-switch 086c4ea: * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch
Date: Fri, 20 Jan 2017 01:10:02 -0800 [thread overview]
Message-ID: <r025shoe2j2t.fsf@dancol.org> (raw)
In-Reply-To: <jwv37ggclak.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Wed, 18 Jan 2017 12:48:53 -0500")
On Wed, Jan 18 2017, Stefan Monnier wrote:
>> * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch
>> Fgethash type checks the provided table object, which is unnecessary
>> for compiled bytecode.
>
> While it's true that we can cause a core dump of Emacs if we feed it an
> invalid .elc file, that's a "feature" I'd rather shrink rather
> than generalize.
Why? If anything, the opposite direction is the right one. elc files
should be tightly coupled to the Emacs that built them so that they can
be specialized for specific machines. You could imagine them
containing, say, saved JIT traces.
next prev parent reply other threads:[~2017-01-20 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170118171311.10996.72260@vcs.savannah.gnu.org>
[not found] ` <20170118171311.A84EA220125@vcs.savannah.gnu.org>
2017-01-18 17:48 ` [Emacs-diffs] feature/byte-switch 086c4ea: * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch Stefan Monnier
2017-01-18 18:19 ` Vibhav Pant
2017-01-19 12:16 ` Vibhav Pant
2017-01-19 16:34 ` Stefan Monnier
2017-01-19 17:53 ` Vibhav Pant
2017-01-20 9:10 ` Daniel Colascione [this message]
2017-01-20 14:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r025shoe2j2t.fsf@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.