From: Daniel Colascione <dancol@dancol.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS
Date: Wed, 21 Dec 2016 20:18:59 -0800 [thread overview]
Message-ID: <r025lgv8iojw.fsf@dancol.org> (raw)
In-Reply-To: <83lgv81vr7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Dec 2016 05:35:24 +0200")
On Thu, Dec 22 2016, Eli Zaretskii wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: emacs-devel@gnu.org
>> Date: Wed, 21 Dec 2016 17:52:47 -0500
>>
>> AFAIK `make-thread` returns a thread object, which you can store
>> anywhere you like. So even if you remove the thread object from
>> all_threads, it may still be referenced from all kinds of other place.
>
> And why is that a problem, both in general and wrt to the change I
> installed that only matters if GC_CHECK_MARKED_OBJECTS is used?
It's a problem because if you don't add thread objects to the tree,
conservative GC doesn't keep them alive and subsequent access to thread
objects can access freed memory. It's perfectly legitimate to hold a
reference to a dead thread --- just like it's perfectly legitimate to
hold a reference to a killed buffer.
next prev parent reply other threads:[~2016-12-22 4:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161221201813.3130.28327@vcs.savannah.gnu.org>
[not found] ` <20161221201813.A13CA2201BA@vcs.savannah.gnu.org>
2016-12-21 20:29 ` [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS Stefan Monnier
2016-12-21 20:40 ` Eli Zaretskii
2016-12-21 22:52 ` Stefan Monnier
2016-12-22 3:35 ` Eli Zaretskii
2016-12-22 3:45 ` Stefan Monnier
2016-12-22 16:17 ` Eli Zaretskii
2016-12-22 4:18 ` Daniel Colascione [this message]
2016-12-22 4:22 ` Daniel Colascione
2016-12-22 16:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r025lgv8iojw.fsf@dancol.org \
--to=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.