From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#25965: 26.0.50; iter-lambda may evaluate certain forms twice Date: Wed, 08 Mar 2017 14:08:07 -0800 Message-ID: References: <87efydcvvr.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489010965 30387 195.159.176.226 (8 Mar 2017 22:09:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 22:09:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25965@debbugs.gnu.org, Andreas Politz To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 08 23:09:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljlc-0006Ki-Q7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 23:09:09 +0100 Original-Received: from localhost ([::1]:58701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cljli-0003tx-8o for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 17:09:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cljlb-0003tb-QL for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 17:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cljlW-0002Fu-S5 for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 17:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cljlW-0002Fk-LB for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 17:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cljlW-0001Bs-CH for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 17:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Mar 2017 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25965-submit@debbugs.gnu.org id=B25965.14890108984522 (code B ref 25965); Wed, 08 Mar 2017 22:09:02 +0000 Original-Received: (at 25965) by debbugs.gnu.org; 8 Mar 2017 22:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:46803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljko-0001As-0Z for submit@debbugs.gnu.org; Wed, 08 Mar 2017 17:08:18 -0500 Original-Received: from dancol.org ([96.126.100.184]:55290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cljkl-0001Aj-P3 for 25965@debbugs.gnu.org; Wed, 08 Mar 2017 17:08:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=vH1Tdv4HUJlfis7auenBWSNQyl/IXxhJAKHdWX9Bb8M=; b=ZVc8GeSx91ge5yBmf9+YIBc+9/S2zO17cWDFERBIiqC9rDAn7Kj3HTpeZwxthaJ+3FL45nl9Hk+k+og1R2sl2Bc5TTWlZ2o5wUVsZYhv1k7/bdrUJC92nQsEJMMLfSNa1xhiuMUuEO+qmjYBEqdksUeXFqWEXFyXrLc7gqAkV2eYcVyjBS0CPy8TiK16i4JlFbcezCXoiKj6uhR9uunAbniqdYjTDZmQYyr29G55TCkoUVDI6f5YIwML4wr+NjczyialDaCg9Duyltlr6Wp41mHs6/bJWSwc63Qhe6qfhQTiTOPFnHA/i/4WRZV+2Ab9cqdru6G+je7i5s4IlxwRYg==; Original-Received: from [2620:0:1009:a:5117:f2bd:1232:5ea7] (helo=thule.roam.corp.google.com) by dancol.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1cljkk-0000Yr-Af; Wed, 08 Mar 2017 14:08:14 -0800 In-Reply-To: (Stefan Monnier's message of "Wed, 08 Mar 2017 16:52:13 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130359 Archived-At: On Wed, Mar 08 2017, Stefan Monnier wrote: >> The unwind-protect form is created in this function. >> >> #+BEGIN_SRC emacs-lisp >> (defun cps--make-dynamic-binding-wrapper (dynamic-var static-var) >> (cl-assert lexical-binding) >> (lambda (form) >> `(let ((,dynamic-var ,static-var)) >> (unwind-protect ; Update the static shadow after evaluation is done >> ,form >> (setf ,static-var ,dynamic-var)) >> ,form))) >> #+END_SRC >> >> And it seems to me that the second occurrence of ,form is just an >> error. > > Hmm... indeed that looks odd, and maybe just removing the second ,form > is the right fix. Daniel, do you happen to remember what the second > ,form above is meant to do? Embarrass me years later? :-) I think it's safe to remove it. Let's make sure to add a test too.