all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#13745: c1-acronyms
@ 2013-02-18 17:00 Per Starbäck
  2016-02-24  5:48 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Per Starbäck @ 2013-02-18 17:00 UTC (permalink / raw)
  To: 13745

In GNU Emacs 24.2.93.1.

char-acronym-table has three entries with "XXX". They are from
lisp/international/characters.el :

> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))

These are the three C1 control characters that are listed with no name
in Unicode and that aren't part of ISO/IEC 6429.

These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
standardized (not accepted to ISO 10646).

  http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
  http://www.aivosto.com/vbtips/control-characters.html

I don't like the acronym feature showing different characters the same,
so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
here.

Alternatively, if that is not OK, that the target c1-control for
glyphless-char-display skips these three characters.

======================================================================
$  diff -cp lisp/international/characters.el lisp/international/characters-fixc1.el
*** lisp/international/characters.el	2013-01-01 21:37:17.000000000 +0100
--- lisp/international/characters-fixc1.el	2013-02-18 17:58:29.103018508 +0100
*************** Setup char-width-table appropriate for n
*** 1354,1363 ****
      (aset char-acronym-table i (car c0-acronyms))
      (setq c0-acronyms (cdr c0-acronyms))))
  
! (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
  		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
  		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
! 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
    (dotimes (i 32)
      (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
      (setq c1-acronyms (cdr c1-acronyms))))
--- 1354,1363 ----
      (aset char-acronym-table i (car c0-acronyms))
      (setq c0-acronyms (cdr c0-acronyms))))
  
! (let ((c1-acronyms '("PAD" "HOP" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
  		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
  		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
! 		     "SOS" "SGCI" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
    (dotimes (i 32)
      (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
      (setq c1-acronyms (cdr c1-acronyms))))

======================================================================





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#13745: c1-acronyms
  2013-02-18 17:00 bug#13745: c1-acronyms Per Starbäck
@ 2016-02-24  5:48 ` Lars Ingebrigtsen
  2016-02-24 17:21   ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-24  5:48 UTC (permalink / raw)
  To: Per Starbäck; +Cc: 13745

starback@stp.lingfil.uu.se (Per Starbäck) writes:

> In GNU Emacs 24.2.93.1.
>
> char-acronym-table has three entries with "XXX". They are from
> lisp/international/characters.el :
>
>> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
>> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>
> These are the three C1 control characters that are listed with no name
> in Unicode and that aren't part of ISO/IEC 6429.
>
> These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
> standardized (not accepted to ISO 10646).
>
>   http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
>   http://www.aivosto.com/vbtips/control-characters.html
>
> I don't like the acronym feature showing different characters the same,
> so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
> here.

If this list is automatically generated from the C1 control code list,
then perhaps that generating function should be removed?

If not, I think your patch is OK, if I understand what it's doing here.
(I may very well be not.)

> ! (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>   		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>   		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> ! 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>     (dotimes (i 32)
>       (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
>       (setq c1-acronyms (cdr c1-acronyms))))
> --- 1354,1363 ----
>       (aset char-acronym-table i (car c0-acronyms))
>       (setq c0-acronyms (cdr c0-acronyms))))
>
> ! (let ((c1-acronyms '("PAD" "HOP" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
>   		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
>   		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> ! 		     "SOS" "SGCI" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
>     (dotimes (i 32)
>       (aset char-acronym-table (+ #x0080 i) (car c1-acronyms))
>       (setq c1-acronyms (cdr c1-acronyms))))
>
> ======================================================================

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#13745: c1-acronyms
  2016-02-24  5:48 ` Lars Ingebrigtsen
@ 2016-02-24 17:21   ` Eli Zaretskii
  2016-02-25  5:52     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2016-02-24 17:21 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: starback, 13745

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 24 Feb 2016 16:48:39 +1100
> Cc: 13745@debbugs.gnu.org
> 
> starback@stp.lingfil.uu.se (Per Starbäck) writes:
> 
> > In GNU Emacs 24.2.93.1.
> >
> > char-acronym-table has three entries with "XXX". They are from
> > lisp/international/characters.el :
> >
> >> (let ((c1-acronyms '("XXX" "XXX" "BPH" "NBH" "IND" "NEL" "SSA" "ESA"
> >> 		     "HTS" "HTJ" "VTS" "PLD" "PLU" "R1"  "SS2" "SS1"
> >> 		     "DCS" "PU1" "PU2" "STS" "CCH" "MW"  "SPA" "EPA"
> >> 		     "SOS" "XXX" "SC1" "CSI" "ST"  "OSC" "PM"  "APC")))
> >
> > These are the three C1 control characters that are listed with no name
> > in Unicode and that aren't part of ISO/IEC 6429.
> >
> > These had the acros PAD, HOP, SGCI in draft DIS 10646, but weren't
> > standardized (not accepted to ISO 10646).
> >
> >   http://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_set
> >   http://www.aivosto.com/vbtips/control-characters.html
> >
> > I don't like the acronym feature showing different characters the same,
> > so I suggest that "XXX" is replaced by the inofficial PAD, HOP, SGCI
> > here.
> 
> If this list is automatically generated from the C1 control code list,
> then perhaps that generating function should be removed?
> 
> If not, I think your patch is OK, if I understand what it's doing here.
> (I may very well be not.)

I'm okay with applying this, thanks.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#13745: c1-acronyms
  2016-02-24 17:21   ` Eli Zaretskii
@ 2016-02-25  5:52     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-25  5:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 13745, starback

Eli Zaretskii <eliz@gnu.org> writes:

>> then perhaps that generating function should be removed?
>> 
>> If not, I think your patch is OK, if I understand what it's doing here.
>> (I may very well be not.)
>
> I'm okay with applying this, thanks.

Ok; applied to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-25  5:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-18 17:00 bug#13745: c1-acronyms Per Starbäck
2016-02-24  5:48 ` Lars Ingebrigtsen
2016-02-24 17:21   ` Eli Zaretskii
2016-02-25  5:52     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.