From: Karl Chen <quarl@cs.berkeley.edu>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: vc-git-show-log-entry
Date: Tue, 21 Oct 2008 00:23:22 -0700 [thread overview]
Message-ID: <quack.20081021T0023.lthej2al8d1@roar.cs.berkeley.edu> (raw)
In-Reply-To: <200810202210.m9KMAALe025685@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon\, 20 Oct 2008 15\:10\:10 -0700 \(PDT\)")
>>>>> On 2008-10-20 15:10 PDT, Dan Nicolaescu writes:
Dan> It moves to the beginning for me. What version of emacs
Dan> are you using?
22.2, and I also mentioned what happens with CVS HEAD in my first
email (though I only tested the relevant functions, didn't build
the entire thing). It only happens 90% of the time for me, I
think because of a race condition from running the subprocess
asynchronously.
>> As I said, if you undo the latest commit to vc-git.el, that
>> fixes it, but I suggest this replacement altogether.
>>
>> (defun vc-git-show-log-entry (rev) (log-view-goto-rev
>> (vc-git-rev-parse rev)))
Dan> Not sure if adding yet another git invocation here is a
Dan> good idea. Please run your change by Alexandre Julliard.
Ah, I assumed you were the one to talk to since you made the
change and you replied to my email. Is Alexandre not on this
mailing list?
next prev parent reply other threads:[~2008-10-21 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 9:36 vc-git-show-log-entry Karl Chen
2008-10-20 15:01 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 15:09 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 18:19 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-20 20:20 ` vc-git-show-log-entry Karl Chen
2008-10-20 22:10 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 7:23 ` Karl Chen [this message]
2008-10-21 8:49 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 17:52 ` vc-git-show-log-entry Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=quack.20081021T0023.lthej2al8d1@roar.cs.berkeley.edu \
--to=quarl@cs.berkeley.edu \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.