From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Kim Newsgroups: gmane.emacs.bugs Subject: bug#15235: 24.3.50; package.el updates load-path too late Date: Sun, 01 Sep 2013 09:45:53 -0700 Message-ID: Reply-To: emacs18@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378054037 2735 80.91.229.3 (1 Sep 2013 16:47:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Sep 2013 16:47:17 +0000 (UTC) To: 15235@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 01 18:47:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VGAo2-0008Eu-BG for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Sep 2013 18:47:18 +0200 Original-Received: from localhost ([::1]:34767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAo1-0005dr-Vo for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Sep 2013 12:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAns-0005WX-Uk for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:47:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGAnm-0007tf-Sa for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:47:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAnm-0007tZ-Oz for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VGAnm-0005LP-DA for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Kim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Sep 2013 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137805399020499 (code B ref -1); Sun, 01 Sep 2013 16:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Sep 2013 16:46:30 +0000 Original-Received: from localhost ([127.0.0.1]:35005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VGAnF-0005KY-By for submit@debbugs.gnu.org; Sun, 01 Sep 2013 12:46:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35562) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VGAnC-0005KL-AG for submit@debbugs.gnu.org; Sun, 01 Sep 2013 12:46:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGAn1-0007np-8W for submit@debbugs.gnu.org; Sun, 01 Sep 2013 12:46:21 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAn1-0007nl-5W for submit@debbugs.gnu.org; Sun, 01 Sep 2013 12:46:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAmv-0005Pe-9U for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:46:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGAmp-0007lj-GC for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:46:09 -0400 Original-Received: from mail-pb0-x229.google.com ([2607:f8b0:400e:c01::229]:38480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGAmp-0007lV-8E for bug-gnu-emacs@gnu.org; Sun, 01 Sep 2013 12:46:03 -0400 Original-Received: by mail-pb0-f41.google.com with SMTP id rp2so3849100pbb.28 for ; Sun, 01 Sep 2013 09:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:reply-to:date:message-id:mime-version:content-type; bh=19Ljx052kyLW9B35LDGeGb3h0s+bxfGKXhzUUljOvFw=; b=Q1dpb6vbBIt7jQviWU0z7x2DcfY/8lMuFTTaogfBFsaMEjfKHaf2ulo0ES86YtH18P h8ts6/k/y04aTNF85eFkjBWSviy7AvpbUKsZl5BFNErvGMzqkoCzZDfS5HMMPitllp4H 41cdBoEVgvuo5wPA99EoUQ7Tlc88QgRHpyFts0sQ2UPHNrA0AyqvfrytGICuuva32uXi JyvFEdw/i9+D6MiXrjrGdIP5IiCMsQ1VA5m+7MjO64ZbYbThfnyk62sJ5I93tVPTWCh9 orA6vDpED2Az7dkVjH328nSAcCbbrhNi8SYYXPzn3+tYIlr409QxOAzmVWmV1i9xOP/i RcKQ== X-Received: by 10.66.170.138 with SMTP id am10mr21612109pac.51.1378053961602; Sun, 01 Sep 2013 09:46:01 -0700 (PDT) Original-Received: from kimr-e6410 (static-50-53-21-49.bvtn.or.frontiernet.net. [50.53.21.49]) by mx.google.com with ESMTPSA id zq10sm11531868pab.6.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 01 Sep 2013 09:46:00 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77864 Archived-At: A recent change made on bzr trunk is causing one of my ELPA packages to fail to load due to `load-path' not being updated promptly. The change in question seems to be Stefan's revision 114047 checked in on Aug 28, 2013 with check in comment Don't add unnecessarily to load-path. The package in question is icicles which I created by putting together a few files from emacswiki.org which I have been using for several years. The problem is that icicles-autoloads.el refers to some custom face which is provided by icicles-face.el in the icicles package directory. However Stefan's change now evaluates icicles-autoloads.el first then updates load-path to add path for icicles. Following shows `package-activate-1' from around August 24: (defun package-activate-1 (pkg-desc) (let* ((name (package-desc-name pkg-desc)) (pkg-dir (package-desc-dir pkg-desc))) (unless pkg-dir (error "Internal error: unable to find directory for `%s'" (package-desc-full-name pkg-desc))) ;; Add info node. (when (file-exists-p (expand-file-name "dir" pkg-dir)) ;; FIXME: not the friendliest, but simple. (require 'info) (info-initialize) (push pkg-dir Info-directory-list)) ;; Add to load path, add autoloads, and activate the package. (push pkg-dir load-path) (load (expand-file-name (format "%s-autoloads" name) pkg-dir) nil t) (push name package-activated-list) ;; Don't return nil. t)) Note that (load) of the "-autolads" file comes after updating of load-path, i.e., (push pkg-dir load-path). Thus icicles-face.el can be found in this version of package.el. Shouldn't load-path updated first for the packge being intialized so that code in "*-autoloads.el" can load other elisp files in the package directory?