patch for org-confluence.el to add menu entry

patch for org-confluence.el to add menu entry

[Richard Kim]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

I would like to suggest the following patch so that I can easily export 
to Confluence wiki format using the usual org-mode export mechanism.

Given the trivial change, I don't think I need to sign any papers.
However I have already signed copyright forms with FSF years ago.

#+begin_src diff
diff --git a/contrib/lisp/ox-confluence.el b/contrib/lisp/ox-confluence.el
index b521b247..c12d1a05 100644
--- a/contrib/lisp/ox-confluence.el
+++ b/contrib/lisp/ox-confluence.el
@@ -60,7 +60,10 @@
 		     (template . org-confluence-template)
 		     (timestamp . org-confluence-timestamp)
 		     (underline . org-confluence-underline)
-		     (verbatim . org-confluence-verbatim)))
+		     (verbatim . org-confluence-verbatim))
+  :menu-entry
+  '(?f "Export to Confluence"
+       ((?f "As Confluence buffer" org-confluence-export-as-confluence))))
 
 (defcustom org-confluence-lang-alist
   '(("sh" . "bash"))
#+end_src




[-- Attachment #2: Type: text/html, Size: 6710 bytes --]

Re: patch for org-confluence.el to add menu entry

[Nicolas Goaziou]

Hello,

Richard Kim <Richard.Kim1@synopsys.com> writes:

> I would like to suggest the following patch so that I can easily export 
> to Confluence wiki format using the usual org-mode export mechanism.

Sure. Could you write a proper commit message and send it again?

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: patch for org-confluence.el to add menu entry

[Richard Kim]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

How about this:

Add key binding for converting org mode to Confluence wiki, i.e.,
'C-x C-e f f' converts current org buffer to a temporary buffer
holding Confluence wiki markup.

This key binding takes effect only when org-confluence.el file
in contrib directory is loaded first.

-------------------------------------------------------

As far as I now, there is no way to make this new key binding work
along with autoload so that it just works.  I think org-confluence.el
has to be loaded first for the key binding to take effect.  I just
need to do (load "org-confluence") in my startup file.

________________________________
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Sent: Saturday, April 11, 2020 2:04 PM
To: Richard Kim <kimr@synopsys.com>
Cc: emacs-orgmode@gnu.org <emacs-orgmode@gnu.org>
Subject: Re: patch for org-confluence.el to add menu entry

Hello,

Richard Kim <Richard.Kim1@synopsys.com> writes:

> I would like to suggest the following patch so that I can easily export
> to Confluence wiki format using the usual org-mode export mechanism.

Sure. Could you write a proper commit message and send it again?

Thank you.

Regards,

--
Nicolas Goaziou

[-- Attachment #2: Type: text/html, Size: 3249 bytes --]

Re: patch for org-confluence.el to add menu entry

[Nicolas Goaziou]

Hello,

Richard Kim <Richard.Kim1@synopsys.com> writes:

> Add key binding for converting org mode to Confluence wiki, i.e.,
> 'C-x C-e f f' converts current org buffer to a temporary buffer
> holding Confluence wiki markup.
>
> This key binding takes effect only when org-confluence.el file
> in contrib directory is loaded first.

Thank you. 

However, I meant a commit message using "git format-patch", for proper
attribution.

Regards,

-- 
Nicolas Goaziou

Re: patch for org-confluence.el to add menu entry

[Bastien]

Hi Richard,

Richard Kim <Richard.Kim1@synopsys.com> writes:

> I would like to suggest the following patch so that I can easily
> export to Confluence wiki format using the usual org-mode export
> mechanism.

I added the menu entry here:
https://code.orgmode.org/bzg/org-mode/commit/cd336c2a

For future contributions as patches, please read this page:
https://orgmode.org/worg/org-contribute.html

Thanks,

-- 
 Bastien