all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Lillibridge <mark.lillibridge@hp.com>
To: 7743@debbugs.gnu.org
Subject: bug#7743: unrmail loses extra blank line at end of message
Date: Mon, 27 Dec 2010 11:54:10 -0800	[thread overview]
Message-ID: <qmhr5d3800t.fsf@hp.com> (raw)


    As of at least Emacs 23.1 and still present in version 24, unrmail
throws away the last blank line of a message if present.  The offending
code is in unrmail.el:

unrmail.el:235:
	    ;; Make sure the message ends with two newlines
	    (goto-char (point-max))
	    (unless (looking-back "\n\n")
	      (insert "\n"))

This is wrong!  Mbox format ends every message with a blank line, which
is not part of the message, so this code by failing to add the necessary
terminator blank line to messages that already end with a blank line
effectively removes the last blank line of such messages.


    The fix is easy: just always add the blank line like so:

unrmail.el:235:
	    ;; Add terminator blank line to message
	    (goto-char (point-max))
	    (insert "\n")


- Mark
PS, the patch for this change hopefully is:

ts-rhel5 [106]% diff original-unrmail.el new-unrmail.el
235c235
<           ;; Make sure the message ends with two newlines
---
>           ;; Add terminator blank line to message
237,238c237
<           (unless (looking-back "\n\n")
<             (insert "\n"))
---
>           (insert "\n")





             reply	other threads:[~2010-12-27 19:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27 19:54 Mark Lillibridge [this message]
2011-11-13 19:59 ` bug#7743: bug #7743: unrmail loses extra blank line at end of message [PATCH] Mark Lillibridge
2011-11-16  7:52 ` bug#7743: unrmail loses extra blank line at end of message Glenn Morris
2011-11-19 20:28   ` Mark Lillibridge
2011-11-23  7:50     ` Glenn Morris
     [not found] ` <handler.7743.D7743.132203471715779.notifdone@debbugs.gnu.org>
2011-11-26  6:06   ` bug#7743: closed (Re: bug#7743: unrmail loses extra blank line at end of message) Mark Lillibridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qmhr5d3800t.fsf@hp.com \
    --to=mark.lillibridge@hp.com \
    --cc=7743@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.