From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#30240: emacs-26; xterm.c: undefined reference to `xg_get_scale' happens with --with-x-toolkit=lucid Date: Wed, 24 Jan 2018 11:44:24 -0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516823014 20080 195.159.176.226 (24 Jan 2018 19:43:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Jan 2018 19:43:34 +0000 (UTC) To: 30240@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 24 20:43:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQwu-0003fE-1J for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 20:43:08 +0100 Original-Received: from localhost ([::1]:41363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeQys-0003UO-MC for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 14:45:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeQym-0003Ti-1t for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:45:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeQyl-0007v4-15 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:45:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeQyk-0007uu-T6 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeQyk-0000Zo-Jc for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2018 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15168230782165 (code B ref -1); Wed, 24 Jan 2018 19:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jan 2018 19:44:38 +0000 Original-Received: from localhost ([127.0.0.1]:41299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQyM-0000Yp-4k for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:44:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQyK-0000Ye-N0 for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:44:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeQyE-0007aU-6v for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:44:31 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eeQyE-0007aQ-3o for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:44:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeQyC-0003O5-S0 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:44:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeQyB-0007ZN-R0 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:44:28 -0500 Original-Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:43266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeQyB-0007Yy-Ja for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 14:44:27 -0500 Original-Received: by mail-pf0-x234.google.com with SMTP id y26so3914221pfi.10 for ; Wed, 24 Jan 2018 11:44:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=e3MCEKaCJFFSnXEM4NpTE+tH/xL0K+mJFAy6FLtf4fk=; b=BDbUNGlIyuRgt9rQQeXYHQz/ELRB62pKdMsi1Eli1YI72sIwrmYcRsO6l/6lQ94gdH FN0BrsM0bWdNT0jkDKMbuLh1r1S03lQi7MdQrTStEg8+o4sC3nGqIE1vIXeX9asJj0CC 7SwFMr8wE6LZ2YMc9x2uZr2782Vy5bse1Wfg2OMAMMXio8rFMVAR6wahXlcsrJSRJVYi oFLEQZK6CSUARskJYKwhUYazYHpdlI2pqjsDEt/UgY2MieuuStSsIBMOI8T2XzFzKVGR UZUYHS2is25ebp18Togp3lqnhZGEbHv1y6/kRO7RtTMpUzUTovqgA13D6Lx38thVZRQl WSag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=e3MCEKaCJFFSnXEM4NpTE+tH/xL0K+mJFAy6FLtf4fk=; b=mEV1H3aW0aaGDlH952HCxMCmCiyuzrQ25rknqttcFyCo6M60ZPWsBXYTrqPoBc3Q2h an6FMZnsS7W/tgaj+nUH5osNu4t9ChbY83+xmWSh29GvanDyk+xJwf7Imp6/2MYAMm4+ 0Y0OC/y1D0CyBiPMdB8b0lG/vT71dgk+5ASWn/OR2gurrqv+CdvAs97dvvj4/I9cTbec vxYPJfiE2DpIZtyNxS0IuZb3rn4yfOM+zhmwAzfMkqRAOUpcbBaE58/OsQhwk3Ak6ub4 6vNsdB2T9RvZSRBwyky5eY5KYnLA5+wutmvQISmk71QXAhHcPKAevQdUd1bFPD1U1gAN MJmg== X-Gm-Message-State: AKwxytfXVSnhU75m/rcJfq2cWFBkB9VDRj9+dQxhf+feXpss9B8FAF46 E7/OVky34YKIhkL8xzXh99YyZbby21g= X-Google-Smtp-Source: AH8x225LNzm8nAXONzvlIPb02aG/tzirNzgukTetQ/JskUw+V/JiE9uuxLJ9JVrNoCZB2zuf9n94mg== X-Received: by 10.99.37.7 with SMTP id l7mr802148pgl.311.1516823065287; Wed, 24 Jan 2018 11:44:25 -0800 (PST) Original-Received: from marmstrong-linux.kir.corp.google.com ([2620:0:1008:11:771f:5f3:ca2f:b612]) by smtp.gmail.com with ESMTPSA id a64sm10861781pfg.89.2018.01.24.11.44.24 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 11:44:24 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142474 Archived-At: I built from the emacs-26 branch: $ git checkout emacs-26 $ git log -l commit 59db8dca030ba6a34d143c3cc6715f02beba1068 (HEAD -> emacs-26, origin/emacs-26) Author: Robert Pluim Date: Wed Jan 24 08:55:34 2018 +0100 Use scaled coordinates when calling into GTK This is part two of a two part fix for the GTK scaling problems. See the thread starting at http://lists.gnu.org/archive/html/emacs-devel/2018-01/msg00372.html for an explanation of why it has been added to Emacs 26. * src/gtkutil.c (xg_set_geometry): Scale down the coordinates that we pass to gtk_window_move and to gtk_window_parse_geometry. * src/xterm.c (x_set_offset): Likewise. $ ./autogen.sh $ ./configure --with-x-toolkit=lucid --prefix=$HOME/opt/emacs-git $ make clean && make bootstrap [...] xterm.c: In function `x_set_offset`: xterm.c:10313:15: warning: implicit declaration of function `xg_get_scale` [-Wimplicit-function-declaration] int scale = xg_get_scale (f); ^~~~~~~~~~~~ xterm.c:10313:3: warning: nested extern declaration of `x_get_scale` [-Wnested-externs] int scale = xg_get_scale (f); ^~~ xterm.c:10313:7: warning: unused variable `scale` [-Wunused-variable] int scale = xg_get_scale (f); ^~~~~ [...] xterm.o: In function `x_set_offset': /usr/local/google/home/marmstrong/git/emacs/src/xterm.c:10313: undefined reference to `xg_get_scale' collect2: error: ld returned 1 exit status Makefile:600: recipe for target 'temacs' failed