From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Klaus Zeitler Newsgroups: gmane.emacs.devel Subject: Re: CVS version: message mode + flyspell terribly slow Date: Thu, 27 Nov 2008 15:06:36 +0100 Message-ID: References: <87iqqa9pc4.fsf@cyd.mit.edu> <871vwy41l2.fsf@cyd.mit.edu> Reply-To: kzeitler@alcatel-lucent.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227795220 12512 80.91.229.12 (27 Nov 2008 14:13:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Nov 2008 14:13:40 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 27 15:14:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L5hdh-0006xY-3h for ged-emacs-devel@m.gmane.org; Thu, 27 Nov 2008 15:14:41 +0100 Original-Received: from localhost ([127.0.0.1]:36451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5hcX-0007Uk-4j for ged-emacs-devel@m.gmane.org; Thu, 27 Nov 2008 09:13:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L5hW4-00047m-Sz for emacs-devel@gnu.org; Thu, 27 Nov 2008 09:06:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L5hW2-00046t-Ot for emacs-devel@gnu.org; Thu, 27 Nov 2008 09:06:47 -0500 Original-Received: from [199.232.76.173] (port=58678 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5hW1-00046c-86 for emacs-devel@gnu.org; Thu, 27 Nov 2008 09:06:45 -0500 Original-Received: from ihemail2.lucent.com ([135.245.0.35]:49326) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L5hW0-0006Av-R9 for emacs-devel@gnu.org; Thu, 27 Nov 2008 09:06:44 -0500 Original-Received: from ihrh1.emsr.lucent.com (h135-1-218-53.lucent.com [135.1.218.53]) by ihemail2.lucent.com (8.13.8/IER-o) with ESMTP id mARE6fci027643; Thu, 27 Nov 2008 08:06:41 -0600 (CST) Original-Received: from nbgif1.de.lucent.com (nbgif1.de.lucent.com [135.246.31.82]) by ihrh1.emsr.lucent.com (8.13.8/emsr) with ESMTP id mARE6chZ007024; Thu, 27 Nov 2008 08:06:39 -0600 (CST) Original-Received: from sfsws1.de.lucent.com (sfsws1.de.lucent.com [135.246.31.38]) by nbgif1.de.lucent.com (8.11.7p3+Sun/8.11.7) with ESMTP id mARE6bj20734; Thu, 27 Nov 2008 15:06:37 +0100 (MET) Original-Received: from sfsw51.de.lucent.com (sfsw51.de.lucent.com [135.246.72.99]) by sfsws1.de.lucent.com (8.13.8/8.12.10) with ESMTP id mARE6aQE017363; Thu, 27 Nov 2008 15:06:36 +0100 (MET) Original-Received: (from kzeitler@localhost) by sfsw51.de.lucent.com (8.11.7p1+Sun/8.8.8) id mARE6aL07804; Thu, 27 Nov 2008 15:06:36 +0100 (MET) X-Authentication-Warning: sfsw51.de.lucent.com: kzeitler set sender to kzeitler@alcatel-lucent.com using -f X-Horoscope: Your programs will start asking for a raise. A warmonger will think of you as your algae. Tomorrow fortune (good or bad) would be a good thing to think about. You'll soon be happy. In-Reply-To: <871vwy41l2.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed\, 26 Nov 2008 16\:30\:33 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (usg-unix-v) X-Scanned-By: MIMEDefang 2.57 on 135.245.2.35 X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106229 Archived-At: >>>>> "Chong" == Chong Yidong writes: Chong> Chong> It turns out that tool-bar-make-keymap is rather expensive, leading Chong> to slowdowns like the above when it is called repeatedly. I'm not Chong> sure why flyspell+message causes it to be called so often, though. Chong> Maybe a gnus hacker can enlighten us. Chong> Chong> If we want to make tool-bar-make-keymap less expensive, one way is Chong> to cache its computed value, in the same way that we cache tool-bar Chong> image specs. See attached patch, which seems to eliminate most of Chong> the slowdown. Thanks for the quick fix and especially for saving me a lot of time in tracing this down (yesterday I started with a CVS version from 31.01.08 and I'm sure it would have taken me a lot of time to find it). I tried the newest version and it's a big improvement. Maybe I should switch the tool-bar of anyway, since I hardly ever use it. I mainly keep it so that my colleagues wont say that emacs is an old fashioned editor :-). Thanks again Klaus -- -------------------------------------------------- | Klaus Zeitler Alcatel-Lucent | | Email: kzeitler@alcatel-lucent.com | -------------------------------------------------- --- There are two ways to write error-free programs. Only the third one works.