From: Ken Olum <kdo@cosmos.phy.tufts.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17560@debbugs.gnu.org
Subject: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set
Date: Tue, 27 May 2014 11:08:06 -0400 [thread overview]
Message-ID: <q5261kr8dk9.fsf@cosmos.phy.tufts.edu> (raw)
In-Reply-To: <83ha4fll8k.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 May 2014 09:54:51 +0300)
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
OK. Here is a different patch making the arguments to
rmail-delete-forward and rmail-delete-backward optional and defaulting
to 1. NEWS and ChangeLog are included.
Ken
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rmail-delete.patch --]
[-- Type: text/x-diff, Size: 1738 bytes --]
=== modified file 'etc/NEWS'
--- etc/NEWS 2014-05-17 08:11:31 +0000
+++ etc/NEWS 2014-05-27 14:50:48 +0000
@@ -130,6 +130,9 @@
** You can access the slots of structures using `cl-struct-slot-value'.
+** Functions `rmail-delete-forward' and `rmail-delete-backward' take an
+optional repeat-count argument.
+
\f
* Changes in Emacs 24.5 on Non-Free Operating Systems
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2014-05-23 15:54:44 +0000
+++ lisp/ChangeLog 2014-05-27 15:04:59 +0000
@@ -1,3 +1,8 @@
+2014-05-27 Ken Olum <kdo@cosmos.phy.tufts.edu>
+
+ * mail/rmail.el (rmail-delete-forward): Default `count' to 1.
+ (rmail-delete-forward): Argument `count' optional, default to 1.
+
2014-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
* minibuffer.el (completion--sreverse): Remove.
=== modified file 'lisp/mail/rmail.el'
--- lisp/mail/rmail.el 2014-05-05 01:08:54 +0000
+++ lisp/mail/rmail.el 2014-05-27 14:53:00 +0000
@@ -3482,6 +3482,7 @@
Returns t if a new message is displayed after the delete, or nil otherwise."
(interactive "p")
+ (if (not count) (setq count 1))
(let (value backward)
(if (< count 0)
(setq count (- count) backward t))
@@ -3496,7 +3497,7 @@
(rmail-maybe-display-summary)
value))
-(defun rmail-delete-backward (count)
+(defun rmail-delete-backward (&optional count)
"Delete this message and move to previous nondeleted one.
Deleted messages stay in the file until the \\[rmail-expunge] command is given.
A prefix argument is a repeat count;
@@ -3505,6 +3506,7 @@
Returns t if a new message is displayed after the delete, or nil otherwise."
(interactive "p")
+ (if (not count) (setq count 1))
(rmail-delete-forward (- count)))
\f
;; Expunging.
next prev parent reply other threads:[~2014-05-27 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 15:02 bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set Ken Olum
2014-05-23 15:31 ` Eli Zaretskii
2014-05-23 15:50 ` Ken Olum
2014-05-23 17:37 ` Eli Zaretskii
2014-05-23 18:48 ` Ken Olum
2014-05-23 19:53 ` Eli Zaretskii
2014-05-23 20:04 ` Ken Olum
2014-05-24 6:54 ` Eli Zaretskii
2014-05-27 15:08 ` Ken Olum [this message]
2014-05-30 9:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q5261kr8dk9.fsf@cosmos.phy.tufts.edu \
--to=kdo@cosmos.phy.tufts.edu \
--cc=17560@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.