From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Cesar Crusius Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make `smtpmail-try-auth-method' a generic function. Date: Thu, 11 Jan 2018 13:36:22 -0800 Message-ID: References: <87373c3olr.fsf@gmail.com> <87shbch2y8.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1515709161 19988 195.159.176.226 (11 Jan 2018 22:19:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2018 22:19:21 +0000 (UTC) User-Agent: mu4e 0.9.18; emacs 25.2.50.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 11 23:19:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZlBr-0004gA-Fo for ged-emacs-devel@m.gmane.org; Thu, 11 Jan 2018 23:19:15 +0100 Original-Received: from localhost ([::1]:47247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZlDq-0003nD-Fx for ged-emacs-devel@m.gmane.org; Thu, 11 Jan 2018 17:21:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZkWT-0007Zk-00 for emacs-devel@gnu.org; Thu, 11 Jan 2018 16:36:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZkWS-0004dr-9B for emacs-devel@gnu.org; Thu, 11 Jan 2018 16:36:29 -0500 Original-Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:38265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZkWS-0004bu-3Y for emacs-devel@gnu.org; Thu, 11 Jan 2018 16:36:28 -0500 Original-Received: by mail-pf0-x22d.google.com with SMTP id k19so2702327pfj.5 for ; Thu, 11 Jan 2018 13:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=TgjjUVyLY1sTFiIABMJs9MWLFqASfIJR0Agp2DVx/n0=; b=rU2dFNkOth8opDUfrfpWrZw92Q5YEhDZNmWqwX7hH011UMyaqF5dmnpCGhg3Yi8y/+ p4i8WtV250Ne86r4WBxwEIqLYs0vF1NcAos8Kf9OWJpgJ1FvQla7CtCHxADshrnoetOQ Y21Rjb25vD3oAy9iRT4oqHljpTvC4N76gLrvitWXYDHrSq/fFm4zWl9PhxF/EEL3LJyY YlSXSWsuS4TOmJdW/m5Zg5ylzMZSoiy4Uapa3KdUckCxbcanxNCU4jlkpFh6QsqtB3Jf PywIKcuvMKRATUhjR/PuvT2uZqbGEyGY/0yhuPNGpUKeZncsy64VDkfjbQ/+UymWvUbT Eyww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=TgjjUVyLY1sTFiIABMJs9MWLFqASfIJR0Agp2DVx/n0=; b=bbofga32eZzgxjrN+bt1K9Q/2CftZqnpBiJu7ghd1wQj6va3JitjhCPsLtCHbcGMOn HIQ7Oy21kdxoImaFlo1x9FEWPmRo2fv6qrLt5Eqa0/jHs33fE/1RQzCjHQJfmWVCgww9 HcYyUcKMynilUqgefqaTRsQyTZ2lvmhtdh/78Mmt1cv4TSvZewIpPR0sOYLPUsjolexb M9x9nDdif4F7pmMxlYQPFYPdDqSM6xCQ+FgzW3zzEhx30yp38p+5jtYf+sKYAfZngxPF Rh4ssJ/WxPQVWPp5owjyWOo0rhYhYFPu8PfLk8ebo4WSJrzfkvCRkztzBkoq+XUHd24V qm0A== X-Gm-Message-State: AKGB3mKLAPwpFNNWuu1ygJSJUvtY+GwkR9rM+pKHMJ7B/+6l/cmIPdL5 yJy5mvUVjV2YDJNpG73Ffb+YZnSH X-Google-Smtp-Source: ACJfBovpEZQuXQJxARzCfrBVTA2wzVh9E7WepOB3DdOekllP5gdEYvYnUdADduNCpq/7u8w++oAgZw== X-Received: by 10.124.22.142 with SMTP id v14mr18324852ply.241.1515706586562; Thu, 11 Jan 2018 13:36:26 -0800 (PST) Original-Received: from ccrusius.svl.corp.google.com ([2620:0:100e:401:512b:13da:76be:91b3]) by smtp.gmail.com with ESMTPSA id u19sm37548887pfh.89.2018.01.11.13.36.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jan 2018 13:36:25 -0800 (PST) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221862 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu 11 Jan 2018 at 19:33, Stefan Monnier wrote: >> That will need an upcoming 'auth-source-xoauth2' package, as getting the >> password involves doing some HTTP fetching. I have the code, just need >> to find some time to add it to MELPA. > > BTW, your library can still work with Emacs-26 (and even Emacs-25) using > a hack like: > > (unless (cl-generic-p 'smtpmail-try-auth-method) > (let ((f (symbol-function 'smtpmail-try-auth-method))) > (fset 'smtpmail-try-auth-method nil) > (cl-generic-define-method 'smtpmail-try-auth-method nil > '(process mech user password) > nil f))) > > which turns the "regular function" smtpmail-try-auth-method into > a "generic function". Yes - and it can also work with Emacs-24 by advising the function instead, which is probably what I'm going to do: if the cl-* functions are there, and smtpmail is one, specialize it, otherwise advise it. =2D-=20 Cesar Crusius --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEEsu/ErKn7yEV7E0FU/X9qSDfQj2EFAlpX2NYACgkQ/X9qSDfQ j2EUvgv+IsPL73hDTDQwqFHS1VsgoN87eTKfMnBTMi7vwjmZbydeknYzAxXo+JL7 o525tn9E6E1Aqte9bspHEnU7ONSTcwaNR0dAuauhpUvvJOLD6nKYhKKEOG1443Ya cw3bNhafKhqoXF6VHXg4aS391VU+wS/02vDkeNFfPJx+p1ObQV3GeXmaLRCY9WvH Q/P2aHk5VTizlyrZpTG/oCJrn39Ul7NlZsD1TJe6a/5qfTHlsck4S8/nU45pNHeC OsLzmr7j4uN8XMpjzzsAEI6o7GFLrDVwWpF6JKjA9kMDhg/nSCZeMx4XnaLC/Tsd YyWnPI5hciZc9kZu0AUWi1cQQ8dQFrlc2tXyl8qbGCAhM2aTzKojimYwtkYnDKVP ORrEgMwp4N5MrcGbeNQbxQzzGZJC1/YMdib6iUwz+Yw9XUffHrJ8hTgUs/waHfJ8 ex46KCHdbkkhj8hd3wKcOBwtb1023awe/LVjnxulTRtBLAxr6Rq62/NtxM8wDtP6 aHSoe5gc =foV1 -----END PGP SIGNATURE----- --=-=-=--