From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; pcmpl-ssh-hosts breaks when known_hosts file has a space in the wrong place Date: Thu, 20 Mar 2008 13:51:34 -0400 Message-ID: References: <8763viza9c.fsf@hagelb.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1206035520 2155 80.91.229.12 (20 Mar 2008 17:52:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2008 17:52:00 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Phil Hagelberg Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 20 18:52:29 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JcOw6-00059K-FS for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2008 18:52:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JcOvW-0007F7-CH for ged-emacs-devel@m.gmane.org; Thu, 20 Mar 2008 13:51:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JcOvS-0007Eu-TN for emacs-devel@gnu.org; Thu, 20 Mar 2008 13:51:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JcOvP-0007EO-B7 for emacs-devel@gnu.org; Thu, 20 Mar 2008 13:51:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JcOvP-0007EL-7C for emacs-devel@gnu.org; Thu, 20 Mar 2008 13:51:35 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JcOvO-0002Zv-Rq for emacs-devel@gnu.org; Thu, 20 Mar 2008 13:51:34 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1JcOvO-0004aL-9m; Thu, 20 Mar 2008 13:51:34 -0400 X-Spook: CDC Blowpipe Medco investigation EuroFed spy Compsec X-Ran: _OYVX;.&#D-fC1:`2-axsjmS2-mK$/ef&v8MeO:C"$Ew X-Hue: white X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93052 gmane.emacs.pretest.bugs:21629 Archived-At: Phil Hagelberg wrote: > The function pcmpl-ssh-hosts (which is invoked when you launch > eshell and type "ssh host") fails when the last entry in your > pcmpl-ssh-known-hosts-file has a space after the hostname instead of > a comma. I don't understand what you mean. Do you mean they changed the format from this: host1,host1a,host1b,... bits exponent modulus comment to this host1 host1a host1b ... bits exponent modulus comment ? > I have a patch to fix this at http://hagelb.org/pcmpl-ssh-space.patch. Err, great. Why not just paste the tiny, tiny patch into your mail? diff -r1.12 pcmpl-unix.el 147c147 < (while (and (looking-back ",") --- > (while (and (looking-back "[ ,]") Isn't this going to pick up all the other, non-hostname, fields as well? If the format has indeed changed in the above way, I guess it will be necessary to count columns, or try more restrictive patterns for the hostnames. The joy of progress...