From: Glenn Morris <rgm@gnu.org>
To: Phil Hagelberg <phil@hagelb.org>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.50; pcmpl-ssh-hosts breaks when known_hosts file has a space in the wrong place
Date: Thu, 20 Mar 2008 13:51:34 -0400 [thread overview]
Message-ID: <pttzj1nv15.fsf@fencepost.gnu.org> (raw)
In-Reply-To: 8763viza9c.fsf@hagelb.org
Phil Hagelberg wrote:
> The function pcmpl-ssh-hosts (which is invoked when you launch
> eshell and type "ssh host<tab>") fails when the last entry in your
> pcmpl-ssh-known-hosts-file has a space after the hostname instead of
> a comma.
I don't understand what you mean. Do you mean they changed the format
from this:
host1,host1a,host1b,... bits exponent modulus comment
to this
host1 host1a host1b ... bits exponent modulus comment
?
> I have a patch to fix this at http://hagelb.org/pcmpl-ssh-space.patch.
Err, great. Why not just paste the tiny, tiny patch into your mail?
diff -r1.12 pcmpl-unix.el
147c147
< (while (and (looking-back ",")
---
> (while (and (looking-back "[ ,]")
Isn't this going to pick up all the other, non-hostname, fields as well?
If the format has indeed changed in the above way, I guess it will be
necessary to count columns, or try more restrictive patterns for the
hostnames. The joy of progress...
next prev parent reply other threads:[~2008-03-20 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 21:14 23.0.50; pcmpl-ssh-hosts breaks when known_hosts file has a space in the wrong place Phil Hagelberg
2008-03-20 17:51 ` Glenn Morris [this message]
[not found] ` <87iqzgx77t.fsf@hagelb.org>
2008-03-24 20:28 ` Glenn Morris
2008-04-09 16:28 ` Phil Hagelberg
2008-04-09 19:29 ` Michael Albinus
2008-04-10 19:52 ` Phil Hagelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pttzj1nv15.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-pretest-bug@gnu.org \
--cc=phil@hagelb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.