From: Ted Zlatanov <tzz@lifelogs.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode
Date: Fri, 26 Jun 2020 13:52:26 +0000 [thread overview]
Message-ID: <pn9mlysl.fsf@lifelogs.com> (raw)
In-Reply-To: <83sgejs25l.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Jun 2020 16:31:02 +0300")
On Thu, 25 Jun 2020 16:31:02 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
EZ> Perhaps if you describe the difficulties you bumped into in more
EZ> detail, we could help you overcome them? AFAICT, you never actually
EZ> described the specific problems you had.
No, I didn't. I spent several hours investigating and the lack of
existing code that did this, plus the complexity of Emacs' display
internals, were discouraging. I didn't keep the attempts I made.
EZ> prettify-symbols-mode (and static compositions in general) just aren't
EZ> the right tool for such jobs; we have much better tools for that, and
EZ> they work well for many other features. I'd be very surprised if
EZ> those tools couldn't support your use cases.
Again, let's consider what I've done as two things:
1) the new minor auth-source-reveal-mode and the prettify-text
library/API: that won't change and has no hard dependency on static
compositions.
2) the internal implementation of the prettify-text library/API: that's
almost exactly like `prettify-symbols-mode', a part of the core. Your
major concern there (accessibility and internationalization) is valid
but it's equally valid against that existing part of the core.
So again, I propose merging as is, and then spending time on a proper
reimplementation for both `prettify-symbols-mode' and the prettify-text
code. I can work on that reimplementation with guidance from this
mailing list. That will help me keep the changes smaller (the branch is
getting hard to maintain) and more targeted.
Thanks
Ted
next prev parent reply other threads:[~2020-06-26 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200622191653.26453.39420@vcs0.savannah.gnu.org>
[not found] ` <20200622191655.E1C4E20A26@vcs0.savannah.gnu.org>
2020-06-22 20:00 ` scratch/tzz/auth-source-reveal-mode f16a4c8 2/3: Support regular expressions and API for prettify-symbols-mode Stefan Monnier
2020-06-22 20:32 ` Ted Zlatanov
[not found] ` <20200622191656.2D20920A26@vcs0.savannah.gnu.org>
2020-06-22 20:03 ` scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode Stefan Monnier
2020-06-22 20:39 ` Ted Zlatanov
2020-06-22 21:09 ` Stefan Monnier
2020-06-23 22:29 ` Ted Zlatanov
2020-06-24 15:13 ` Eli Zaretskii
2020-06-24 18:15 ` Ted Zlatanov
2020-06-24 18:36 ` Eli Zaretskii
2020-06-24 19:04 ` Ted Zlatanov
2020-06-25 13:31 ` Eli Zaretskii
2020-06-26 13:52 ` Ted Zlatanov [this message]
2020-06-26 14:24 ` Eli Zaretskii
2020-06-26 14:39 ` Ted Zlatanov
2020-07-12 20:49 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pn9mlysl.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.