From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13257: GNU Emacs 24.2.1: dired-do-query-replace-regexp calls query-replace-regexp with 3 arguments instead of 2. Date: Sat, 22 Dec 2012 22:15:41 -0500 Message-ID: References: <86a9t5r3mg.fsf@marcade.biz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1356232609 10133 80.91.229.3 (23 Dec 2012 03:16:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Dec 2012 03:16:49 +0000 (UTC) Cc: 13257@debbugs.gnu.org To: Bernard Hurley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 23 04:17:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tmc3j-0002be-By for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2012 04:17:03 +0100 Original-Received: from localhost ([::1]:42810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tmc3V-0004x2-5S for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2012 22:16:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tmc3Q-0004wx-8x for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 22:16:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tmc3M-0006K5-JI for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 22:16:44 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tmc3M-0006K1-Fd for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 22:16:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tmc3i-00050t-If for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2012 22:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2012 03:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13257-submit@debbugs.gnu.org id=B13257.135623256719193 (code B ref 13257); Sun, 23 Dec 2012 03:17:02 +0000 Original-Received: (at 13257) by debbugs.gnu.org; 23 Dec 2012 03:16:07 +0000 Original-Received: from localhost ([127.0.0.1]:56055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmc2p-0004zW-2i for submit@debbugs.gnu.org; Sat, 22 Dec 2012 22:16:07 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:54451) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tmc2m-0004zN-TD for 13257@debbugs.gnu.org; Sat, 22 Dec 2012 22:16:05 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tmc2P-0007Pi-I2; Sat, 22 Dec 2012 22:15:41 -0500 X-Spook: SRI Guantanamo Albright Ruby Ridge Glock monarchist red X-Ran: wY43}qf)4k,y)aNq;".Kfg&g9%G1|nzq-c(FM=~kX\oOa9!q}Geu{d85Bp_~`|DnFJ%?S| X-Hue: yellow X-Attribution: GM In-Reply-To: <86a9t5r3mg.fsf@marcade.biz> (Bernard Hurley's message of "Sun, 23 Dec 2012 00:52:55 +0000") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68932 Archived-At: Bernard Hurley wrote: > In the file dired-aux.el, the function query-replace-regexp is called > with the wrong number of arguments. Here is a patch: You talk about query-replace-regexp, but your patch changes a call to query-replace-read-args, which takes 2-3 args, so I wonder what the actual issue is supposed to be? > *** dired-aux.el.old 2012-12-23 00:42:49.000000000 +0000 > --- dired-aux.el.new 2012-12-23 00:48:39.000000000 +0000 > *************** > *** 2511,2517 **** > (interactive > (let ((common > (query-replace-read-args > ! "Query replace regexp in marked files" t t))) > (list (nth 0 common) (nth 1 common) (nth 2 common)))) > (dolist (file (dired-get-marked-files nil nil 'dired-nondirectory-p)) > (let ((buffer (get-file-buffer file))) > --- 2511,2517 ---- > (interactive > (let ((common > (query-replace-read-args > ! "Query replace regexp in marked files" t))) > (list (nth 0 common) (nth 1 common) (nth 2 common)))) > (dolist (file (dired-get-marked-files nil nil 'dired-nondirectory-p)) > (let ((buffer (get-file-buffer file)))