From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Re: Font-lock in COMINT modes (again) Date: Wed, 31 Jan 2007 18:06:07 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1170292008 3721 80.91.229.12 (1 Feb 2007 01:06:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Feb 2007 01:06:48 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 01 02:06:32 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HCQPH-0000jE-RJ for ged-emacs-devel@m.gmane.org; Thu, 01 Feb 2007 02:06:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HCQPH-0007e7-AD for ged-emacs-devel@m.gmane.org; Wed, 31 Jan 2007 20:06:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HCQP7-0007dt-UL for emacs-devel@gnu.org; Wed, 31 Jan 2007 20:06:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HCQP5-0007dh-Fc for emacs-devel@gnu.org; Wed, 31 Jan 2007 20:06:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HCQP5-0007de-A2 for emacs-devel@gnu.org; Wed, 31 Jan 2007 20:06:19 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HCQP4-00041X-OV for emacs-devel@gnu.org; Wed, 31 Jan 2007 20:06:18 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HCQP2-0005Pt-Ia for emacs-devel@gnu.org; Thu, 01 Feb 2007 02:06:16 +0100 Original-Received: from turtle.as.arizona.edu ([128.196.208.207]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 01 Feb 2007 02:06:16 +0100 Original-Received: from jdsmith by turtle.as.arizona.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 01 Feb 2007 02:06:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: turtle.as.arizona.edu User-Agent: Pan/0.14.2.91 (As She Crawled Across the Table) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65728 Archived-At: On Tue, 23 Jan 2007 13:46:18 -0700, JD Smith wrote: > At the time I proposed this simple patch to fix this: > > *** comint.el 28 Nov 2006 11:25:56 -0700 1.350 --- comint.el 07 Dec 2006 > 10:54:48 -0700 *************** > *** 653,659 **** > (make-local-variable 'comint-accum-marker) (setq comint-accum-marker > (make-marker)) (make-local-variable 'font-lock-defaults) > ! (setq font-lock-defaults '(nil)) > (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This > behavior is not useful in comint buffers, and is annoying (set > (make-local-variable 'next-line-add-newlines) nil)) > --- 653,659 ---- > (make-local-variable 'comint-accum-marker) (setq comint-accum-marker > (make-marker)) (make-local-variable 'font-lock-defaults) > ! (setq font-lock-defaults '(nil t)) > (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This > behavior is not useful in comint buffers, and is annoying (set > (make-local-variable 'next-line-add-newlines) nil)) > > Should I install it? We concluded that it would not result in any > performance penalty, and I assume (but don't know, never used it) the > facemenu issue the original change addresses wouldn't be adversely > affected. This patch has now been checked in.