From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Font-lock in COMINT modes (again) Date: Tue, 23 Jan 2007 13:46:18 -0700 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1169585212 2481 80.91.229.12 (23 Jan 2007 20:46:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2007 20:46:52 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 23 21:46:46 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H9SXV-00024B-IL for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2007 21:46:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H9SXV-0002ZB-0X for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2007 15:46:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H9SXI-0002Yo-FY for emacs-devel@gnu.org; Tue, 23 Jan 2007 15:46:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H9SXH-0002Yc-7i for emacs-devel@gnu.org; Tue, 23 Jan 2007 15:46:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H9SXH-0002YZ-4a for emacs-devel@gnu.org; Tue, 23 Jan 2007 15:46:31 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H9SXG-0003k8-Ip for emacs-devel@gnu.org; Tue, 23 Jan 2007 15:46:30 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1H9SXE-0000NF-Ep for emacs-devel@gnu.org; Tue, 23 Jan 2007 21:46:28 +0100 Original-Received: from turtle.as.arizona.edu ([128.196.208.207]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Jan 2007 21:46:28 +0100 Original-Received: from jdsmith by turtle.as.arizona.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Jan 2007 21:46:28 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 36 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: turtle.as.arizona.edu User-Agent: Pan/0.14.2.91 (As She Crawled Across the Table) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65423 Archived-At: In Dec. we had a discussion about comint's new default of fontifying strings and comments, due to the change: ---------------------------- revision 1.348 date: 2006-09-28 19:09:19 +0000; author: rms; state: Exp; lines: +4 -1 (comint-mode): Bind font-lock-defaults non-nil. ---------------------------- At the time I proposed this simple patch to fix this: *** comint.el 28 Nov 2006 11:25:56 -0700 1.350 --- comint.el 07 Dec 2006 10:54:48 -0700 *************** *** 653,659 **** (make-local-variable 'comint-accum-marker) (setq comint-accum-marker (make-marker)) (make-local-variable 'font-lock-defaults) ! (setq font-lock-defaults '(nil)) (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This behavior is not useful in comint buffers, and is annoying (set (make-local-variable 'next-line-add-newlines) nil)) --- 653,659 ---- (make-local-variable 'comint-accum-marker) (setq comint-accum-marker (make-marker)) (make-local-variable 'font-lock-defaults) ! (setq font-lock-defaults '(nil t)) (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This behavior is not useful in comint buffers, and is annoying (set (make-local-variable 'next-line-add-newlines) nil)) Should I install it? We concluded that it would not result in any performance penalty, and I assume (but don't know, never used it) the facemenu issue the original change addresses wouldn't be adversely affected. JD