Font-lock in COMINT modes (again)

Font-lock in COMINT modes (again)

[JD Smith]

In Dec. we had a discussion about comint's new default of fontifying
strings and comments, due to the change:

----------------------------
revision 1.348
date: 2006-09-28 19:09:19 +0000;  author: rms;  state: Exp;  lines: +4 -1
(comint-mode): Bind font-lock-defaults non-nil.
----------------------------

At the time I proposed this simple patch to fix this:

*** comint.el	28 Nov 2006 11:25:56 -0700	1.350 --- comint.el	07 Dec 2006
10:54:48 -0700 ***************
*** 653,659 ****
    (make-local-variable 'comint-accum-marker) (setq comint-accum-marker
    (make-marker)) (make-local-variable 'font-lock-defaults)
!   (setq font-lock-defaults '(nil))
    (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This
    behavior is not useful in comint buffers, and is annoying (set
    (make-local-variable 'next-line-add-newlines) nil))
--- 653,659 ----
    (make-local-variable 'comint-accum-marker) (setq comint-accum-marker
    (make-marker)) (make-local-variable 'font-lock-defaults)
!   (setq font-lock-defaults '(nil t))
    (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This
    behavior is not useful in comint buffers, and is annoying (set
    (make-local-variable 'next-line-add-newlines) nil))

Should I install it?  We concluded that it would not result in any
performance penalty, and I assume (but don't know, never used it) the
facemenu issue the original change addresses wouldn't be adversely
affected.

JD

Re: Font-lock in COMINT modes (again)

[JD Smith]

On Tue, 23 Jan 2007 13:46:18 -0700, JD Smith wrote:

> At the time I proposed this simple patch to fix this:
> 
> *** comint.el	28 Nov 2006 11:25:56 -0700	1.350 --- comint.el	07 Dec 2006
> 10:54:48 -0700 ***************
> *** 653,659 ****
>     (make-local-variable 'comint-accum-marker) (setq comint-accum-marker
>     (make-marker)) (make-local-variable 'font-lock-defaults)
> !   (setq font-lock-defaults '(nil))
>     (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This
>     behavior is not useful in comint buffers, and is annoying (set
>     (make-local-variable 'next-line-add-newlines) nil))
> --- 653,659 ----
>     (make-local-variable 'comint-accum-marker) (setq comint-accum-marker
>     (make-marker)) (make-local-variable 'font-lock-defaults)
> !   (setq font-lock-defaults '(nil t))
>     (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This
>     behavior is not useful in comint buffers, and is annoying (set
>     (make-local-variable 'next-line-add-newlines) nil))
> 
> Should I install it?  We concluded that it would not result in any
> performance penalty, and I assume (but don't know, never used it) the
> facemenu issue the original change addresses wouldn't be adversely
> affected.

This patch has now been checked in.