From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#14068: [PATCH] Officially support DragonFly BSD Date: Thu, 18 Apr 2013 01:46:04 -0400 Message-ID: References: <5152F41B.1090707@marino.st> <515C2D07.5010208@marino.st> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1366263997 12999 80.91.229.3 (18 Apr 2013 05:46:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Apr 2013 05:46:37 +0000 (UTC) Cc: 14068@debbugs.gnu.org To: John Marino Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 18 07:46:41 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UShg8-0003UC-Lh for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Apr 2013 07:46:40 +0200 Original-Received: from localhost ([::1]:42484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UShg8-0005Cw-B3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Apr 2013 01:46:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UShg5-0005Cr-3w for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 01:46:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UShg3-0000sQ-Pt for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 01:46:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UShg3-0000sM-Ll for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 01:46:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UShkL-0002JQ-P4 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2013 01:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2013 05:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14068-submit@debbugs.gnu.org id=B14068.13662642358841 (code B ref 14068); Thu, 18 Apr 2013 05:51:01 +0000 Original-Received: (at 14068) by debbugs.gnu.org; 18 Apr 2013 05:50:35 +0000 Original-Received: from localhost ([127.0.0.1]:57828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UShju-0002IY-VB for submit@debbugs.gnu.org; Thu, 18 Apr 2013 01:50:35 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:53884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UShjs-0002IR-IV for 14068@debbugs.gnu.org; Thu, 18 Apr 2013 01:50:34 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UShfY-0001gy-Qy; Thu, 18 Apr 2013 01:46:04 -0400 X-Spook: Bellcore Jyllandsposten M-14 data haven Blowpipe World X-Ran: \;[[/smq_p'!`#e#>1? (John Marino's message of "Wed, 03 Apr 2013 15:22:15 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73484 Archived-At: John Marino wrote: > The previously submitted patch was for release 24.3. > The patch to add DragonFly support to version 24.3.50.112178 is much > smaller: > https://raw.github.com/jrmarino/DPorts/staged/editors/emacs-devel/dragonfly/patch-configure.ac + case "${canonical}" in + i[3456]86-*-dragonfly*) machine=intel386 ;; + amd64-*-dragonfly*|x86_64-*-dragonfly*) machine=amdx86-64 ;; + esac machine is no longer used, so these lines are unnecessary. - freebsd) LIBS_SYSTEM="-lutil" ;; + freebsd|netbsd|openbsd|dragonfly) LIBS_SYSTEM="-lutil" ;; Why are you adding netbsd and openbsd as well? Apart from that, it seems fine to me. It's probably just small enough not to need a copyright assignment; but for the ChangeLog, can you tell me who the author is? Revised patch against current trunk: --- configure.ac 2013-04-18 05:03:53 +0000 +++ configure.ac 2013-04-18 05:43:24 +0000 @@ -439,6 +439,11 @@ opsys=freebsd ;; + ## DragonFly ports + *-*-dragonfly* ) + opsys=dragonfly + ;; + ## FreeBSD kernel + glibc based userland *-*-kfreebsd*gnu* ) opsys=gnu-kfreebsd @@ -968,7 +973,7 @@ LD_SWITCH_SYSTEM= case "$opsys" in - freebsd) + freebsd|dragonfly) ## Let `ld' find image libs and similar things in /usr/local/lib. ## The system compiler, GCC, has apparently been modified to not ## look there, contrary to what a stock GCC would do. @@ -1054,7 +1059,7 @@ ## IBM's X11R5 uses -lIM and -liconv in AIX 3.2.2. aix4-2) LIBS_SYSTEM="-lrts -lIM -liconv" ;; - freebsd) LIBS_SYSTEM="-lutil" ;; + freebsd|dragonfly) LIBS_SYSTEM="-lutil" ;; hpux*) LIBS_SYSTEM="-l:libdld.sl" ;; @@ -1095,7 +1100,7 @@ ## Adding -lm confuses the dynamic linker, so omit it. LIB_MATH= ;; - freebsd ) + freebsd | dragonfly ) SYSTEM_TYPE=berkeley-unix ;; gnu-linux | gnu-kfreebsd ) @@ -2866,7 +2871,7 @@ case "$opsys" in aix4-2) mail_lock="lockf" ;; - gnu|freebsd|netbsd|openbsd|darwin|irix6-5) mail_lock="flock" ;; + gnu|freebsd|dragonfly|netbsd|openbsd|darwin|irix6-5) mail_lock="flock" ;; ## On GNU/Linux systems, both methods are used by various mail programs. ## I assume most people are using newer mailers that have heard of flock. @@ -3038,7 +3043,7 @@ fi ;; - openbsd) LIBS_TERMCAP="-lncurses" ;; + openbsd | dragonfly) LIBS_TERMCAP="-lncurses" ;; ## hpux: Make sure we get select from libc rather than from libcurses ## because libcurses on HPUX 10.10 has a broken version of select. @@ -3461,7 +3466,7 @@ esac case $opsys in - darwin | freebsd | netbsd | openbsd ) + darwin | dragonfly | freebsd | netbsd | openbsd ) AC_DEFINE(DONT_REOPEN_PTY, 1, [Define if process.c does not need to close a pty to make it a controlling terminal (it is already a controlling terminal of the subprocess, because we did ioctl TIOCSCTTY).]) @@ -3567,7 +3572,7 @@ AC_DEFINE(FIRST_PTY_LETTER, ['p']) ;; - gnu-linux | gnu-kfreebsd | freebsd | netbsd ) + gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd ) dnl if HAVE_GRANTPT if test "x$ac_cv_func_grantpt" = xyes; then AC_DEFINE(UNIX98_PTYS, 1, [Define if the system has Unix98 PTYs.]) @@ -3650,7 +3655,7 @@ case $opsys in dnl Perry Smith says this is correct for AIX. dnl thomas@mathematik.uni-bremen.de says this is needed for IRIX. - aix4-2 | cygwin | gnu | irix6-5 | freebsd | netbsd | openbsd | darwin ) + aix4-2 | cygwin | gnu | irix6-5 | dragonfly | freebsd | netbsd | openbsd | darwin ) AC_DEFINE(SIGNALS_VIA_CHARACTERS, 1) ;; @@ -3699,7 +3704,7 @@ case $opsys in darwin) AC_DEFINE(TAB3, OXTABS) ;; - gnu | freebsd | netbsd | openbsd ) + gnu | dragonfly | freebsd | netbsd | openbsd ) AC_DEFINE(TABDLY, OXTABS, [Undocumented.]) AC_DEFINE(TAB3, OXTABS) ;; @@ -3753,7 +3758,7 @@ else case $opsys in dnl irix: Tested on Irix 6.5. SCM worked on earlier versions. - freebsd | netbsd | openbsd | irix6-5 | sol2* ) + dragonfly | freebsd | netbsd | openbsd | irix6-5 | sol2* ) AC_DEFINE(GC_SETJMP_WORKS, 1) ;; esac