Re: Async rebuild package-quickstart after packages update? was Re: 28.0.50; Proposal: slightly more efficient package-quickstart.el

["T.V Raman" <raman@google.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1642 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:


Here is the updated patch:
git diff master
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 37dcbe36c8..4e59623cbc 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -4138,7 +4138,12 @@ package--quickstart-maybe-refresh
   (if package-quickstart
       ;; FIXME: Delay refresh in case we're installing/deleting
       ;; several packages!
-      (package-quickstart-refresh)
+      (start-process
+       "quickstart" " *quickstart*"
+       (expand-file-name invocation-name invocation-directory)
+       "-batch" "-q"
+       "-l" "package"
+       "-f" "package-quickstart-refresh")
     (delete-file (concat package-quickstart-file "c"))
     (delete-file package-quickstart-file)))
 
>> From: "T.V Raman" <raman@google.com>
>> Cc: arthur.miller@live.com,  emacs-devel@gnu.org
>> Date: Wed, 04 Aug 2021 17:22:23 -0700
>> 
>> Here is a simple patch that rebuilds package-quickstart-file in a
>> separate emacs process:
>
> Thanks.  I have one minor comment:
>
>> -      (package-quickstart-refresh)
>> +      (start-process
>> +       "quickstart" "*quickstart*" "emacs"
>> +       "-batch" "-q"
>> +       "-l" "package"
>> +       "-f" "package-quickstart-refresh")
>
> The 3rd argument of start-process should use
>
>   (expand-file-name invocation-name invocation-directory)
>
> instead of the literal "emacs", so that it invokes the same Emacs
> binary as the one in which the command runs.
>

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8