From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 09:01:02 -0700 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Eli Zaretskii , Stefan Monnier , Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 18:04:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1magjj-00043U-43 for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 18:04:11 +0200 Original-Received: from localhost ([::1]:40302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1magjh-0003eb-D5 for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 12:04:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maggu-0007Bk-NT for emacs-devel@gnu.org; Wed, 13 Oct 2021 12:01:16 -0400 Original-Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:33703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maggr-0002OL-60 for emacs-devel@gnu.org; Wed, 13 Oct 2021 12:01:16 -0400 Original-Received: by mail-pj1-x1036.google.com with SMTP id q10-20020a17090a1b0a00b001a076a59640so3923478pjq.0 for ; Wed, 13 Oct 2021 09:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=PpiCmbRauTV2rk30vMsb1y2IEmKQDxkRNuv5FsR1va4=; b=hKu71jyP8yB6ashSHQCLX65s6P8US02qahCeN7tzsFGkf/HiaR+Hksww16Q1dDcgZl adPd+B85kZx9aPEve1XU7Z9jiSlbpUR/VS+uS/jY2vNxblIMg9HHjALGWc1Fyrx7OTv4 8rSExswr0obB9uF0+UEtCGdEaY47zI1BfZ1Y+Ahq1OQbsZMh2i46HxvTBGjLGl5teeyp fyYHs9CnLRnGjsiDPcEAOuuOvNDBWKsUAtaCEgef/ThYKgIZfGS91JtjjhHG7krWIB+B HFEcxo5Bi/QkNS40CpcJ/lped4WaLSHsgVfk4+3IRPAeZaNVOt0jxslhyLPX2Rdkt8AL KRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=PpiCmbRauTV2rk30vMsb1y2IEmKQDxkRNuv5FsR1va4=; b=7wTOdBftQRfJ4IB4wdddgWmbu/YUPIzZFnZaq3b0i9yCsEXrf/Z4DyIRNJpRvt5u9t 1jrKp/TdsqoFlevKtW5fhT9z+LuMGv+LbHcmd0/IsiVEDj14ICtDFdB+LzfXq5EiJcA2 LWPi8Jz5PnhjUpGne8uu+v0MbhOqbxV32+lQn/26IaT4+hlV6SyH5zkajRqyzhPSvvRS vN7NSiF3nkQK/25sYLu1pVOuant6DhcP1DlKfRcdtMhprR4OH8Y/s3vqyk13ieaW/NLi L6zVWzHeMCk2a5HHT5ruxCmvdhUbfuXOIDanHxZQOkaNXehWnGdvzuHp8L32Ze9ED831 b8bA== X-Gm-Message-State: AOAM530j68svlGWlI1/PVdKLtwYv5ezy1d4m6NQ4rnCJ+JRjNrHPcsUs igFb/wMDJMdZwo6WX+crkrml1Kt7LXVtZA== X-Google-Smtp-Source: ABdhPJzegtqJYlAVTKMQ5/mPBvVku7VIx4Rrjpz9ry7Wxa9nQ9CLo9R8MaLLVMUb9mLmFEvIhVo8Tw== X-Received: by 2002:a17:902:f683:b0:13f:a79:52de with SMTP id l3-20020a170902f68300b0013f0a7952demr59122plg.43.1634140865537; Wed, 13 Oct 2021 09:01:05 -0700 (PDT) Original-Received: from raman-glaptop (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id t28sm14795668pfq.158.2021.10.13.09.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 09:01:04 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Wed, 13 Oct 2021 17:03:24 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=raman@google.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276921 Archived-At: Stefan Kangas writes: Yes, you'd need to fix at least that documented incompatibility and likely others; it shows that writing lots of tests for that function are really important. If nothing else, rewriting it made the code (at least to me) readable; the implementation from reading kbd macros was pretty well incomprehensible at least to my reading of it. > Stefan Kangas writes: > >> Is your 'new-kbd' intended to be bug-for-bug compatible with 'kbd', or >> have there been any functional changes along the way? Are you >> suggesting that we could perhaps just replace 'kbd' with your new >> version? (One observation is that your version still uses the cl- >> functions, so it would need adjusting for subr.el.) > > Now I note the following comments: > > ;;; Tests: > ;;; Note that we fail on > ;;; "M-ESC" > ;;; "M-" > ;;; "H-" etc, > ;;; But match on "H-RET" > ;;; (thanks Drew Adams) Likely due to over-optimization. > > So I guess we could borrow ideas from your code but not use it as a > drop-in replacement in its current form. > --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =817=A94 Id: kg:/m/0285kf1 =950=DC8