eww: call to eww-render looks incorrect

eww: call to eww-render looks incorrect

[raman]

In function eww:

eww-render is the callback to url-retrieve: line 267
(url-retrieve url 'eww-render
		(list url nil (current-buffer))))
The order of arguments in that list looks wrong --- at least per
the definition of eww-render, which is (status url buffer &rest args)

-- 

Re: eww: call to eww-render looks incorrect

[Eli Zaretskii]

> Date: Sat, 02 Sep 2017 15:38:09 -0700
> From: raman <raman@google.com>
> 
> In function eww:
> 
> eww-render is the callback to url-retrieve: line 267
> (url-retrieve url 'eww-render
> 		(list url nil (current-buffer))))
> The order of arguments in that list looks wrong --- at least per
> the definition of eww-render, which is (status url buffer &rest args)

In the current master eww-render's signature is

  (defun eww-render (status url &optional point buffer encode)

So I think the CBARGS argument of url-retrieve in that case is
correct, do you agree?

Re: eww: call to eww-render looks incorrect

[raman]

Eli Zaretskii <eliz@gnu.org> writes:

I might be confused -- reading that signature I thought status should be
 passed first, the call I see passes url first >> Date: Sat, 02 Sep 2017 15:38:09 -0700
>> From: raman <raman@google.com>
>> 
>> In function eww:
>> 
>> eww-render is the callback to url-retrieve: line 267
>> (url-retrieve url 'eww-render
>> 		(list url nil (current-buffer))))
>> The order of arguments in that list looks wrong --- at least per
>> the definition of eww-render, which is (status url buffer &rest args)
>
> In the current master eww-render's signature is
>
>   (defun eww-render (status url &optional point buffer encode)
>
> So I think the CBARGS argument of url-retrieve in that case is
> correct, do you agree?

-- 

Re: eww: call to eww-render looks incorrect

[Eli Zaretskii]

> From: raman <raman@google.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 03 Sep 2017 08:52:20 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> I might be confused -- reading that signature I thought status should be
> passed first, the call I see passes url first

No, status is not included in the list of arguments.  The doc string
says:

  (url-retrieve URL CALLBACK &optional CBARGS SILENT INHIBIT-COOKIES)

  Retrieve URL asynchronously and call CALLBACK with CBARGS when finished.
  URL is either a string or a parsed URL.  If it is a string
  containing characters that are not valid in a URI, those
  characters are percent-encoded; see ‘url-encode-url’.

  CALLBACK is called when the object has been completely retrieved, with
  the current buffer containing the object, and any MIME headers associated
  with it.  It is called as (apply CALLBACK STATUS CBARGS).
  STATUS is a plist representing what happened during the request,

As you see, only CBARGS are taken from the call to url-retrieve, the
status is added when the callback is invoked.

Re: eww: call to eww-render looks incorrect

[raman]

Eli Zaretskii <eliz@gnu.org> writes:

thanks -- I was clearly confused.>> From: raman <raman@google.com>
>> Cc: emacs-devel@gnu.org
>> Date: Sun, 03 Sep 2017 08:52:20 -0700
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> I might be confused -- reading that signature I thought status should be
>> passed first, the call I see passes url first
>
> No, status is not included in the list of arguments.  The doc string
> says:
>
>   (url-retrieve URL CALLBACK &optional CBARGS SILENT INHIBIT-COOKIES)
>
>   Retrieve URL asynchronously and call CALLBACK with CBARGS when finished.
>   URL is either a string or a parsed URL.  If it is a string
>   containing characters that are not valid in a URI, those
>   characters are percent-encoded; see ‘url-encode-url’.
>
>   CALLBACK is called when the object has been completely retrieved, with
>   the current buffer containing the object, and any MIME headers associated
>   with it.  It is called as (apply CALLBACK STATUS CBARGS).
>   STATUS is a plist representing what happened during the request,
>
> As you see, only CBARGS are taken from the call to url-retrieve, the
> status is added when the callback is invoked.

--