From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: shr-copy-url: arg misnamed? Date: Sun, 23 Sep 2018 16:45:01 -0700 Message-ID: References: <20180922161218.BA963C20207@raman-glaptop.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537746231 4187 195.159.176.226 (23 Sep 2018 23:43:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Sep 2018 23:43:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 24 01:43:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4E2U-0000xx-DU for ged-emacs-devel@m.gmane.org; Mon, 24 Sep 2018 01:43:46 +0200 Original-Received: from localhost ([::1]:42873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4E4a-0005ur-VF for ged-emacs-devel@m.gmane.org; Sun, 23 Sep 2018 19:45:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4E3v-0005uj-UB for emacs-devel@gnu.org; Sun, 23 Sep 2018 19:45:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4E3q-0007RS-W5 for emacs-devel@gnu.org; Sun, 23 Sep 2018 19:45:15 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:40687) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4E3p-0007Mr-2k for emacs-devel@gnu.org; Sun, 23 Sep 2018 19:45:09 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id n31-v6so1486490pgm.7 for ; Sun, 23 Sep 2018 16:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZpLbKuwkrKIbnucaJeaMr/ZBjrwo8bWI5y4UqRq4whU=; b=ccwIKTh7k59UDUQ8wPoy8kpnxKgIKdksuB0GKzjtRgOETg/VqK2mr2r7WFnGyYLw7J MhtfUJVwTdXDijPf6lYytXIQ0rIhtfuHYDLAtjP+V1gEcFajejNJ0FG59k1BNcwwPYII Cy5/usK/SeTWUtw0/MYf5Rsa6ovCYT5KKEwvktQ5Oo4GZ7UTeQiQ0V5FzT3gdpSEvifp GgPK/qVatRIEjji8DrwxwNSSE6us67tA0sn/JMXKPwDc9t9c0mUFv62DXX1Y9daR9j8/ Zfysf7/amReynP1aRng7dWJadZ7YqLKEX3FMAWGDuDHjzIXqrFA1jnsDjMF18g2wwsV5 0XNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZpLbKuwkrKIbnucaJeaMr/ZBjrwo8bWI5y4UqRq4whU=; b=Hjp4/s1nmzfiPvjFm7PIlp5PWcZ07GouUsxVHrqXkKSQyq5YXi+DSvXgaq84Nuoo+R EBuozLe6CWD02IrPL4gqIGHjpC4WYxj9BLDUfHfVUV9M8orTiqOOkn50X2guQG/lp3SZ SkNMydaw/e0MWCMOE4WHxAyKZrbTownPRdRx7BUBsBRm4zxhUhSuuwNkH+U0mRPTUGqZ V/3QoRvAlvV2F9S6ehu/AekQUCoy2KG9MySjGBzarB1WyL+Yak9EMqM+jneF3UHV1Hkf in2Fea5i06TJeKe2PvolYOSYqru2BhVueC4FJXXNVHVi8fmUheCya3NzukO4s/ze3FYq Mvpw== X-Gm-Message-State: APzg51AQN2XMmHaLiVgK2A/pDrAmrULoSPybfDO5POMG3fFMkfqTz4AZ CSZnmyRpUIvoRmTMC3J5bG+URQ== X-Google-Smtp-Source: ANB0Vdba5UzE17XOsSKc7JjuOxfqcckOyNAawck3EU2zzddzauNRtbPKVSDnflHh5yxaf8x62kMx6g== X-Received: by 2002:a62:f553:: with SMTP id n80-v6mr4201348pfh.59.1537746306915; Sun, 23 Sep 2018 16:45:06 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id m20-v6sm70616556pfg.61.2018.09.23.16.45.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Sep 2018 16:45:04 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id 0032DC20300; Sun, 23 Sep 2018 16:45:01 -0700 (PDT) In-Reply-To: (Noam Postavsky's message of "Sun, 23 Sep 2018 16:04:40 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::530 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230012 Archived-At: Noam Postavsky writes: What I meant was: Interactive form returns "url" to fill-in its arg (url) --- agree re the cut-and-paste error. Not sure why I typed "shadowed" -- what I meant was that the naming of "url" is confusing (interactive (list (shr-url-at-point current-prefix-arg))) > On Sat, 22 Sep 2018 at 12:22, T.V Raman wrote: >> >> Should the arg in this function be renamed? >> >> The name "url" is confusing, and is likely being shadowed > > Not sure what you mean by shadowed, but the docstring has a copy-paste > mistake: it should say "with a prefix argument" instead of referencing > IMAGE-URL (which is an arg of shr-url-at-point). --