From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#40688: 28.0.50; Advice And ByteCompile Behavior Change Date: Sun, 03 May 2020 08:27:37 -0700 Message-ID: References: Reply-To: "T.V Raman" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102443"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40688@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 03 17:28:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVGXO-000QZH-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 17:28:14 +0200 Original-Received: from localhost ([::1]:58942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVGXN-0008Ev-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 11:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVGXC-0008ER-UH for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 11:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVGXC-0007aH-Km for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVGXC-0005sw-H8 for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "T.V Raman" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2020 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40688 X-GNU-PR-Package: emacs Original-Received: via spool by 40688-submit@debbugs.gnu.org id=B40688.158851966722598 (code B ref 40688); Sun, 03 May 2020 15:28:02 +0000 Original-Received: (at 40688) by debbugs.gnu.org; 3 May 2020 15:27:47 +0000 Original-Received: from localhost ([127.0.0.1]:57686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVGWx-0005sQ-5S for submit@debbugs.gnu.org; Sun, 03 May 2020 11:27:47 -0400 Original-Received: from mail-pl1-f176.google.com ([209.85.214.176]:39132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVGWw-0005sB-4k for 40688@debbugs.gnu.org; Sun, 03 May 2020 11:27:46 -0400 Original-Received: by mail-pl1-f176.google.com with SMTP id s20so5773627plp.6 for <40688@debbugs.gnu.org>; Sun, 03 May 2020 08:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TMNHGkXLPF01mhDuiuV4nOMk6AGIAAMiG/Mduv6G/9k=; b=WGtwnEfXqGEX4szWKu5KKSP0otxh4B2/j28VP2M7tXEAGhT5MsnXCz3xMLw3aE4wli zlMaIRzMxKizfWusubPby66pzaxHp+cmWnfXuAEKq0yJ52X+rp70Lsm/iZxVszeC/A5Z QOkOe8xTCYkz4RibrunP1HaxZch8++EsoSSKwY5vQwtktOVQffCBrBCDs6ZaKvpv2AY5 ZC3+UFz51rXiTCvtw9ZDXSLVV/1qoRzhHQ/7tIXuEY3i1V1O8vzylmwXse9REkuoTnHy WyKcPXRtTDh6/o9ty5AbKwfVJK0YbgRaTMxle+qw44zqGtIhpB78fV5jhQ1SZjJmR8Df K/oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TMNHGkXLPF01mhDuiuV4nOMk6AGIAAMiG/Mduv6G/9k=; b=Y1YnFhlRgNfLbwbsg4N1nbu5wf7RSPRiXDuByQMHcvSCwGc6q4+8xlY5+OsHqGV62A PxPTfR2t0ell+PrZc7lh1Ciz2DnnKlD1G0XuJ9Qk39FSi2bQCJlYWBA7/nLQguBdIXZp tI15h+XwYFkTHPhZvOZowKUKVAKYWc0NkoY5WHfaXPM+S7pi271zWDSO/bLkRtwoJx2X wxWmYYqPPQueJx1/arw+BF9QfDzG3YS7Y8UdB6AUs0ApclIH3BOm3Uk8ePNOrupMwghM GCd/S+TO2Lcy50XqUk8Y2WAmojYmjR0rkpiJrzXh7C+cuGYGvKJonwIRyu39yyn1FXhZ CuOQ== X-Gm-Message-State: AGi0PubMrM9ZFPow6zEmHKG0PHewz8tXKsdC7KN86K4CL9aOOjTNmJ05 sUb+8jIeRaPRa9L5beOh4tdZXjwOnNC4tw== X-Google-Smtp-Source: APiQypJpflTOypUCMvliKEIeYkmPbEO3D/miIPrmZWHNjGS+WwVz2nGrpaBNzeXXZVhGuOZ7zksQKg== X-Received: by 2002:a17:90a:fd94:: with SMTP id cx20mr11684576pjb.157.1588519659480; Sun, 03 May 2020 08:27:39 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id a99sm4605194pje.35.2020.05.03.08.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 08:27:38 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id 7AA57C21E45; Sun, 3 May 2020 08:27:37 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 03 May 2020 11:08:44 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179592 Archived-At: Stefan Monnier writes: I didn't mean the -j bit in building emacs, conjecture is that emacspeak breaks if -j is used. >> 4. As mentioned in this bug report at the outset I started seeing >> strange behavior (that also appeared non-deterministic across builds) >> where it felt like some of the advice was not defined (incidentally when >> the bug bit yesterday, C-h o still indicated the functions were >> adviced). > > If it bites again, could you try and post (to the extent possible, > obviously) the function name, the output of (symbol-function > ) along with as much as possible a concrete and detailed > description of an actual call's behavior on that function where we see > that the advice wasn't called? > >> So wild conjecture: Given make -j (the Makefile does impose some >> dependency order but not all) >> is it possible that things go south if something that is needed during >> the build of module-a.el gets byte-compiled *after* module-a.el? > > In theory, no. I (and many other people) build Emacs's `lisp` subdir in > parallel, and there are basically no dependencies in the makefile to try > and make sure files get compiled before they're used. We've had some > corner case problems with it, but all the ones I know have been fixed. > > > Stefan > > >> Stefan Monnier writes: >> >>> IIUC after recompiling everything the problem disappeared. If you >>> can't reproduce it any more, than I guess we can only close this >>> bug. >>> >>>> As an example, Module emacspeak-advice.el advices vc-next-action --- and >>>> this module (emacspeak-advice) is loaded early on during emacspeak >>>> initialization. >>>> >>>> When I later call vc-next-action during an emacs session and the >>>> autoload pulls in vc.el, the advice definition loaded earlier is not >>>> activated -- I have to explicitly reload module emacspeak-advice. >>> >>> In case you can still reproduce the problem, please show us what >>> `C-h o vc-next-action` tells you when you think it should have the >>> advice applied yet its behavior doesn't seem to be affected. >>> >>> >>> Stefan >>> > --