From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: defadvice bug or something else? Date: Wed, 28 Apr 2021 20:15:40 -0700 Message-ID: References: <87fsz9swcf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Tim Cross , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 05:16:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbxAK-0005Bf-6r for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 05:16:36 +0200 Original-Received: from localhost ([::1]:54024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbxAJ-00019W-9R for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 23:16:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbx9Y-0000ki-Fz for emacs-devel@gnu.org; Wed, 28 Apr 2021 23:15:48 -0400 Original-Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:37680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbx9U-0006wB-GB for emacs-devel@gnu.org; Wed, 28 Apr 2021 23:15:47 -0400 Original-Received: by mail-pf1-x430.google.com with SMTP id b15so880193pfl.4 for ; Wed, 28 Apr 2021 20:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=eISrSdQURyFXW+K4aci+2pEHSXyJz49EwXknltdzcss=; b=c8ZeH++LY+4QT6RPvpmlJ+J7PM0ISOqJ1F1AVLGbRhL4+tqemjtqsm5bXi45rHPng/ Ur4HkjTtKM4mNd75NOh/NfAaTf5PkhPIXhoMAiq9eA2mPncz/SWBn4l0c23qXszO9rQQ /nLeqiLk96Veq9Y2nnsSxCCqXAtUDsx9DSl8PlS9JEEmkRBi1F2yq5lf/Sq0T6UnO/HH frgg6sDQ7PRjhSpvlBT9KEMVZ6HPcx67/GU3jE+D2q1f7ZQc8kFvMgvc1gQuxA0oJmVo K3OoclIejmm3ITlXJJiKrbWaCY+4YfcDOVX2OKIINrxYsPWeDhy7DILm/U/E1Cn0jpJi eKNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=eISrSdQURyFXW+K4aci+2pEHSXyJz49EwXknltdzcss=; b=imLsKRQCvkululaM5Aw/p2I55YRPxSus7C3rKdkL1tjYyBG98qnEp3NuhfOtbjIS1S lF+1+bxZJSbrc0E3CjZ8smHRC1hKgxkbZOQrTvnsmcc8CxS0kWpQux/GT2OdeK2sKnYJ SFi76Y/OTxwhObOcDuO4FwNxF4AVfidufs2uf9s79z+Y97c5qG35NTGnuG0NsLr7MlNG sZJpuqdFCzYqUvJ4qw300gvhcANXUAagA7ySYE1go8QJNGKO71K+XdSsuON6QlN0TmIT C4rzXqsEcE0qlu8wsMWY+f90Jh9zj3DuloAnqnNEXOTJGDFWuorP9xN2aHv4DOq3K/yE +8WQ== X-Gm-Message-State: AOAM532NHUT+lxtLqAM9TEtU9dgwdfI4LGYKuzVwjPtDbZQFqKur7G5D qVk57CPmcjdc4Fb3LgpDwUTk5w== X-Google-Smtp-Source: ABdhPJwCo0g+HJ/X+DDPtdXVXamYfOEPhTlt62G+K+YPFWyPqZ9KSA3uFolYii2evX0DU/K8ucwd1w== X-Received: by 2002:a63:e509:: with SMTP id r9mr30517268pgh.384.1619666142570; Wed, 28 Apr 2021 20:15:42 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id n24sm915028pfv.170.2021.04.28.20.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 20:15:41 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id D4FE7C2189B; Wed, 28 Apr 2021 20:15:40 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 28 Apr 2021 22:07:09 -0400") Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=raman@google.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268597 Archived-At: Thanks Tim for posting the repro case, and thanks Stefan for the pointer to the optional 'update arg to window -end -- this fixes the bug in emacspeak that Tim reported recently. Stefan Monnier writes: >> `(defadvice ,f (after emacspeak pre act comp) >> (message "scroll advice: start =3D %d end =3D %d diff =3D %d" >> (window-start) >> (window-end) >> (- (window-end) (window-start)))))) > > I think this may return outdated values for `window-end` because it is > run before the window end position has been recomputed by redisplay. > If that's not what you want, then you need to pass non-nil value for the > `update` argument. > > > Stefan > > --=20 Thanks, --Raman =817=A94 Id: kg:/m/0285kf1 =950=DC8